This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Synchronization tweaks for IPC services #2028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
Pull request needs code review.
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 31, 2016
NikVolf
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Aug 31, 2016
@@ -42,7 +42,7 @@ pub struct ModuleState { | |||
|
|||
#[derive(Ipc)] | |||
pub trait ControlService { | |||
fn shutdown(&self); | |||
fn shutdown(&self) -> bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a return type forces invocation to be synchronous
Until the exact issue will be found
NikVolf
changed the title
using sequentally consistent checks in control service
Synchronization tweaks for IPC services
Aug 31, 2016
ctrl-c crashed the node with the following error:
|
and after some time (looks like process was not closed)
|
@debris probably you have orphanned process running while starting another one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2027