This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
IPC tweaks #2046
Merged
IPC tweaks #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2fc7090 on ipc-tweaks-3 into * on master*. |
| @@ -39,7 +41,7 @@ impl IoHandler<ClientIoMessage> for ClientIoHandler { | |||
| } | |||
|
|
|||
| fn timeout(&self, _io: &IoContext<ClientIoMessage>, timer: TimerToken) { | |||
| if let INFO_TIMER = timer { | |||
| if timer == INFO_TIMER && !self.shutdown.load(Ordering::SeqCst) { | |||
There was a problem hiding this comment.
what makes this check necessary? does the informant block and the IoManager's event loop can't finish?
There was a problem hiding this comment.
@rphmeier
Timer tries to request data from sync service which can be already shutdown
|
What's the reason to have debug setting with lower timeout? |
|
(LGTM modulo the above grumble) |
|
@arkpar |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PARITY_IPC_DEBUG)