This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
mitigate refcell conflict in state diffing #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses RefCell::get_mut in a few places.
rphmeier
added
A0-pleasereview 🤓
|
Test to cover the bug would be nice. |
gavofyork
added
A5-grumble 🔥
|
grumble for test |
rphmeier
added
A0-pleasereview 🤓
|
Added a test case which is confirmed to panic on master and passes on this branch. There may be other borrowing issues, but it will require significant changes in |
tomusdrw
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Oct 14, 2016
* mitigate refcell conflict in state diffing Also uses RefCell::get_mut in a few places. * Add test case
arkpar
added a commit
that referenced
this pull request
Oct 14, 2016
* v1.3.8 * mitigate refcell conflict in state diffing (#2601) * mitigate refcell conflict in state diffing Also uses RefCell::get_mut in a few places. * Add test case * Fixed stalled sync * Fixed tx queue limit for local transactions (#2616) * Fixed tx queue limit for local tx * Fixing test * Increas gas limit to 20x * Additional logs when transactions is removed from queue (#2617) * Database performance tweaks (#2619)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2600
I also switched a few uses of
borrow_muttoget_mut, which should lead to better overall correctness.These RefCells are pretty dangerous, and the strange mishmash of interior and actual mutability in this structure can lead to correctness issues, not to mention some slight runtime overhead.
It can probably be refactored a bit to make it safer. Use of
RefCellshould be considered similar toOption::unwrap.