-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
jacogr
commented
Dec 9, 2016
- Add last block timestamp, Closes https://github.com/ethcore/parity/issues/3170
- alignment between containers to fit in with other pages
- simplify ui/Page to optionally create actionbar
@@ -18,7 +18,7 @@ | |||
.layout { | |||
padding: 0.25em 0.25em 1em 0.25em; | |||
|
|||
> * { | |||
margin-bottom: 0.75em; | |||
&>div { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for that ? The &
is useless, and we might not want to limit to div
s. padding
instead of margin
is what was breaking the event
pannel in Contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without that approach, you get a border around the full Page + Actionbar, instead of just the content below. So We are saying - only add border around the direct decendents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrap the above, wrong comment, been too long between writing and review. Will need to go back and see why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapped to margin.
I recall now. The reasson why this was originally introduced (not this PR actually, this was just supposed to move stuff around) it to not make the fixed statusbar at the bottom overlap with the page. Any other solution and you start having funnies across the different pages, e.g. dapps as well.
May be good to have a re-look at this in your fixes branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is supposed to be a property of the .page
class and not its descendants. That's why there is padding: 0.25em 0.25em 1em 0.25em
for the Page
Component. Anyway, looks good now :)
const classes = `${styles.layout} ${className}`; | ||
let actionbar = null; | ||
|
||
if (title || buttons) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixed some case-sensitivity issues too. Can't MacOS be set as case-sensitive ? |
Driving me crazy a bit. Been using the tests/builds to pick the case sensitivity up. |