Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing decoding ABI with signatures in names #4125

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Fixing decoding ABI with signatures in names #4125

merged 1 commit into from
Jan 11, 2017

Conversation

tomusdrw
Copy link
Collaborator

Closes #4122

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Jan 11, 2017
@tomusdrw tomusdrw changed the title Fixing decoding API with signatures in names Fixing decoding ABI with signatures in names Jan 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7672c4e on abi-spec into ** on master**.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 11, 2017
@gavofyork gavofyork merged commit 26500af into master Jan 11, 2017
@gavofyork gavofyork deleted the abi-spec branch January 11, 2017 11:17
gavofyork pushed a commit that referenced this pull request Jan 11, 2017
* Ignore get_price_info test by default. (#4112)

* Auto-detect hex encoded bytes in sha3 (#4108)

* Auto-detect hex encoded bytes in sha3

* Using types/isHex

* Removing unused imports

* Use binary chop to estimate gas accurately (#4100)

* Initial sketch.

* Building.

* Fix a few things.

* Fix issue, add tracing.

* Address grumbles

* Raise upper limit if needed

* Fix test.

* Fixing decoding API with signatures in names (#4125)

* Fix call/estimate_gas (#4121)

* Return 0 instead of error with out of gas on estimate_gas

* Fix stuff up.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants