-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Removes dependency on rustc_serialize (#5988) #6705
Conversation
It looks like @0x7CFE hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, plesae reply to this thread with Many thanks, Parity Technologies CLA Bot |
I don't think benchmarks data is relevant here, only code executed |
Doesn't the whisper crate currently use 0.9? |
@rphmeier no, only |
Cargo.lock
Outdated
@@ -811,6 +811,7 @@ dependencies = [ | |||
"rust-crypto 0.2.36 (registry+https://github.com/rust-lang/crates.io-index)", | |||
"rustc-hex 1.0.0 (registry+https://github.com/rust-lang/crates.io-index)", | |||
"rustc-serialize 0.3.24 (registry+https://github.com/rust-lang/crates.io-index)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed, you most forgot to remove rust-serialize
from util/network/Cargo.toml
and ethcore/Cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, looks like I searched using underscore instead of dash.
Affects #5988.
util/network
was migrated to serde 1.0rustc_hex
Looks like these were the last dependencies that used
rustc_serialize
.Default test suite passes:
Fixed bench shows the following stats:
Just in case, here are my CPU specs: