Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Removes dependency on rustc_serialize (#5988) #6705

Merged
merged 3 commits into from
Oct 11, 2017
Merged

Conversation

0x7CFE
Copy link
Contributor

@0x7CFE 0x7CFE commented Oct 11, 2017

Affects #5988.

  • util/network was migrated to serde 1.0
  • ethcore bench was fixed and adapted to use rustc_hex

Looks like these were the last dependencies that used rustc_serialize.

Default test suite passes:

test result: ok. 84 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Fixed bench shows the following stats:

running 4 tests
test bn_128_mul     ... bench:     619,273 ns/iter (+/- 12,419)
test bn_128_pairing ... bench:   6,367,055 ns/iter (+/- 10,457)
test ecrecover      ... bench:     117,225 ns/iter (+/- 7,253)
test sha256         ... bench:       1,227 ns/iter (+/- 64)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured; 0 filtered out

Just in case, here are my CPU specs:

lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                12
On-line CPU(s) list:   0-11
Thread(s) per core:    2
Core(s) per socket:    6
Socket(s):             1
NUMA node(s):          1
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 63
Model name:            Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz
Stepping:              2
CPU MHz:               1281.738
CPU max MHz:           4000,0000
CPU min MHz:           1200,0000
BogoMIPS:              7012.16
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              15360K
NUMA node0 CPU(s):     0-11
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm epb tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm xsaveopt cqm_llc cqm_occup_llc dtherm ida arat pln pts

@0x7CFE 0x7CFE requested review from debris and arkpar October 11, 2017 11:01
@parity-cla-bot
Copy link

It looks like @0x7CFE hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M4-core ⛓ Core client code / Rust. labels Oct 11, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 11, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 11, 2017
@NikVolf
Copy link
Contributor

NikVolf commented Oct 11, 2017

I don't think benchmarks data is relevant here, only code executed Bencher::iter is measured

@rphmeier
Copy link
Contributor

Doesn't the whisper crate currently use 0.9?

@debris
Copy link
Collaborator

debris commented Oct 11, 2017

@rphmeier no, only 1.0 is used now

Cargo.lock Outdated
@@ -811,6 +811,7 @@ dependencies = [
"rust-crypto 0.2.36 (registry+https://github.com/rust-lang/crates.io-index)",
"rustc-hex 1.0.0 (registry+https://github.com/rust-lang/crates.io-index)",
"rustc-serialize 0.3.24 (registry+https://github.com/rust-lang/crates.io-index)",
Copy link
Collaborator

@debris debris Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, you most forgot to remove rust-serialize from util/network/Cargo.toml and ethcore/Cargo.toml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, looks like I searched using underscore instead of dash.

@debris debris added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Oct 11, 2017
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 11, 2017
@debris debris merged commit bfff19c into master Oct 11, 2017
@debris debris deleted the serde-migration branch October 11, 2017 16:17
@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 11, 2017
@5chdn 5chdn modified the milestones: 1.9, 1.8 Oct 11, 2017
@5chdn 5chdn mentioned this pull request Oct 11, 2017
67 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants