Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Migrate to serde 1.0 #5988

Closed
6 tasks done
debris opened this issue Jul 4, 2017 · 6 comments
Closed
6 tasks done

Migrate to serde 1.0 #5988

debris opened this issue Jul 4, 2017 · 6 comments
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@debris
Copy link
Collaborator

debris commented Jul 4, 2017

  • migrate crates which utilize serde 0.9 to serde 1.0
  • migrate executables which use docopt 0.7 to docopt 0.8
  • migrate toml from 0.2 to 0.4
  • migrate code that uses rustc_serialize::json::Json
    • ethcore/src/miner/price_info.rs
    • util/network/src/node_table.rs
@debris debris added the M4-core ⛓ Core client code / Rust. label Jul 4, 2017
@5chdn 5chdn added P7-nicetohave 🐕 Issue is worth doing eventually. F6-refactor 📚 Code needs refactoring. labels Sep 5, 2017
@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 10, 2017

What is the status for this issue? I think I could handle it, if it's not taken.

@debris
Copy link
Collaborator Author

debris commented Oct 10, 2017

I believe we still use rustc_serialize in several places

ethcore/benches/evm.rs:24:extern crate rustc_serialize;
ethcore/benches/evm.rs:78:      use rustc_serialize::hex::FromHex;
util/network/src/lib.rs:72:extern crate rustc_serialize;
util/network/src/node_table.rs:35:pub use rustc_serialize::json::Json;

@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 10, 2017

What about ethcore/src/miner/price_info.rs? I couldn't see this path on master.

@debris
Copy link
Collaborator Author

debris commented Oct 10, 2017

it was relocated to price-info/src/lib.rs and it's already updated and uses serde

@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 12, 2017

Looks like we've finished all of the related work. Should this issue be closed for now?

@debris
Copy link
Collaborator Author

debris commented Oct 12, 2017

yes, definitely!

@debris debris closed this as completed Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

3 participants