Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

migration to serde 1.0 #5996

Merged
merged 19 commits into from
Jul 6, 2017
Merged

migration to serde 1.0 #5996

merged 19 commits into from
Jul 6, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 4, 2017

Partly addresses #5988

@debris debris added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Jul 4, 2017
@debris debris requested a review from tomusdrw July 4, 2017 16:32
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 5, 2017
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 5, 2017
@tomusdrw
Copy link
Collaborator

tomusdrw commented Jul 5, 2017

@paritytech/ci Where are the tests?

@debris debris added the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jul 5, 2017
@tomusdrw tomusdrw closed this Jul 5, 2017
@tomusdrw tomusdrw reopened this Jul 5, 2017
@rphmeier
Copy link
Contributor

rphmeier commented Jul 6, 2017

#6009 still uses serde 0.9 but upgrading should be pretty trivial. This should be merged first and then I'll port the whisper RPC over.

@debris debris removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jul 6, 2017
@rphmeier rphmeier merged commit 104367c into master Jul 6, 2017
@rphmeier rphmeier deleted the serdeup branch July 6, 2017 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants