Track dropped candidates #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreim
reviewed
Apr 24, 2024
| .filter(|candidate| !candidate.is_included()) | ||
| .collect(); | ||
| // We have more than one backed candidate | ||
| // because of session change or availability core timeout |
There was a problem hiding this comment.
Shouldn't we drop all candidates pending availability when new session is detected rather than rely on this artifact of having more than one after session change ?
There was a problem hiding this comment.
It's a good question.
We could've cleaned them on session change, but we still have to keep in mind that a candidate may be dropped after a core timeout.
Do you think we should separate that cases?
There was a problem hiding this comment.
Generally it is not a good idea to build logic on top of side effects. If this fixes it quickly, yeah let's do it, but let's properly handle session changes and otherwise the only reason you could have more than 1 candidate is elastic scaling.
sandreim
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we change our method of candidate tracking, we faced a bug with increased backing counts. Was found that we don't remove from tracker candidates that were dropped on session change.
This PR fixes state pruning for dropped candidates. These candidates are visible only in CLI mode, nothing goes to Prometheus. Also added visual only event for candidates pending availability.