-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is there a src/lib.rs
file with only comments?
#11
Comments
These are the docs following the sentiment to use rustdoc and keep readmes as a light intro. However it doesn't quite work here because the package gets replaced with a workspace root. And the template crates are not published to any registry, so there is no way to read those rustdocs without cloning the repo (e.g. on mobile). So for these reasons I think templates should be the exception and avoid rustdocs for introductory documentation, instead have it right in the readme - so we can remove @gupnik Do you agree with that? |
I agree, if your auto-generation process can remove this, it makes sense to me. |
the only place they can be seen is in https://paritytech.github.io/polkadot-sdk/master/minimal_template/index.html I think these were added when the template had no good readme. Now that it has, they can be removed, or bere a mere duplicate of the readme |
This removes the workspace of the minimal template, which (I think) is redundant. The other two templates do not have such a workspace. The synchronized template created [it's own workspace](https://github.com/paritytech/polkadot-sdk-minimal-template/blob/master/Cargo.toml) anyway, and the new readme replaced the old docs contained in `lib.rs`. Closes paritytech/polkadot-sdk-minimal-template#11 Silent because the crate was private.
https://github.com/paritytech/polkadot-sdk-minimal-template/blob/master/src/lib.rs
Why does this file exist in the template?
The text was updated successfully, but these errors were encountered: