Eliminate experimental feature (#3654)

Totally removes the `experimental` feature. Closes #3648. --------- Co-authored-by: Bastian Köcher <git@kchr.de>
paritytech · Mar 17, 2024 · 1f9505c · 1f9505c
1 parent d2a7100
commit 1f9505c
Show file tree

Hide file tree

Showing 41 changed files with 15 additions and 120 deletions.
diff --git a/cumulus/pallets/collator-selection/Cargo.toml b/cumulus/pallets/collator-selection/Cargo.toml
@@ -77,5 +77,3 @@ try-runtime = [
  "pallet-timestamp/try-runtime",
  "sp-runtime/try-runtime",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/pallets/collator-selection/src/mock.rs b/cumulus/pallets/collator-selection/src/mock.rs
@@ -125,7 +125,6 @@ impl pallet_aura::Config for Test {
  type MaxAuthorities = ConstU32<100_000>;
  type DisabledValidators = ();
  type AllowMultipleBlocksPerSlot = ConstBool<false>;
- #[cfg(feature = "experimental")]
  type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
 }
 

diff --git a/cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml b/cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml
@@ -251,8 +251,6 @@ std = [
  "xcm/std",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -723,7 +720,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml b/cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml
@@ -236,8 +236,6 @@ std = [
  "xcm/std",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
@@ -171,10 +171,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -703,7 +700,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml
@@ -296,7 +296,6 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
 fast-runtime = []
 
 # A feature that should be enabled when the runtime should be built for on-chain

diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
@@ -277,10 +277,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -445,7 +442,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml
@@ -246,8 +246,6 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs
@@ -251,10 +251,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -407,7 +404,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/collectives/collectives-westend/Cargo.toml b/cumulus/parachains/runtimes/collectives/collectives-westend/Cargo.toml
@@ -232,8 +232,6 @@ std = [
  "xcm/std",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs b/cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs
@@ -184,10 +184,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -483,7 +480,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/contracts/contracts-rococo/Cargo.toml b/cumulus/parachains/runtimes/contracts/contracts-rococo/Cargo.toml
@@ -196,8 +196,6 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs b/cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs
@@ -193,10 +193,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = pallet_timestamp::weights::SubstrateWeight<Runtime>;
 }
 
@@ -349,7 +346,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml b/cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml
@@ -194,6 +194,4 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 fast-runtime = []
diff --git a/cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs b/cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
@@ -206,10 +206,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -369,7 +366,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml b/cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml
@@ -190,6 +190,4 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 fast-runtime = []
diff --git a/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs b/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
@@ -206,10 +206,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -369,7 +366,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/glutton/glutton-westend/Cargo.toml b/cumulus/parachains/runtimes/glutton/glutton-westend/Cargo.toml
@@ -135,8 +135,6 @@ try-runtime = [
  "sp-runtime/try-runtime",
 ]
 
-experimental = ["pallet-aura/experimental"]
-
 # A feature that should be enabled when the runtime should be built for on-chain
 # deployment. This will disable stuff that shouldn't be part of the on-chain wasm
 # to make it smaller, like logging for example.

diff --git a/cumulus/parachains/runtimes/glutton/glutton-westend/src/lib.rs b/cumulus/parachains/runtimes/glutton/glutton-westend/src/lib.rs
@@ -221,10 +221,7 @@ impl cumulus_pallet_aura_ext::Config for Runtime {}
 impl pallet_timestamp::Config for Runtime {
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -233,7 +230,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/people/people-rococo/Cargo.toml b/cumulus/parachains/runtimes/people/people-rococo/Cargo.toml
@@ -188,5 +188,3 @@ try-runtime = [
  "polkadot-runtime-common/try-runtime",
  "sp-runtime/try-runtime",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/people/people-rococo/src/lib.rs b/cumulus/parachains/runtimes/people/people-rococo/src/lib.rs
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -337,7 +334,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/people/people-westend/Cargo.toml b/cumulus/parachains/runtimes/people/people-westend/Cargo.toml
@@ -188,5 +188,3 @@ try-runtime = [
  "polkadot-runtime-common/try-runtime",
  "sp-runtime/try-runtime",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/people/people-westend/src/lib.rs b/cumulus/parachains/runtimes/people/people-westend/src/lib.rs
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
 }
 
@@ -337,7 +334,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }
 

diff --git a/cumulus/parachains/runtimes/starters/seedling/Cargo.toml b/cumulus/parachains/runtimes/starters/seedling/Cargo.toml
@@ -79,5 +79,3 @@ std = [
  "sp-version/std",
  "substrate-wasm-builder",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/starters/seedling/src/lib.rs b/cumulus/parachains/runtimes/starters/seedling/src/lib.rs
@@ -213,17 +213,13 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<false>;
- #[cfg(feature = "experimental")]
  type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
 }
 
 impl pallet_timestamp::Config for Runtime {
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ parachains_common::SLOT_DURATION / 2 }>;
  type WeightInfo = ();
 }
 

diff --git a/cumulus/parachains/runtimes/starters/shell/Cargo.toml b/cumulus/parachains/runtimes/starters/shell/Cargo.toml
@@ -99,5 +99,3 @@ try-runtime = [
  "parachain-info/try-runtime",
  "sp-runtime/try-runtime",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/starters/shell/src/lib.rs b/cumulus/parachains/runtimes/starters/shell/src/lib.rs
@@ -241,17 +241,13 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<false>;
- #[cfg(feature = "experimental")]
  type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
 }
 
 impl pallet_timestamp::Config for Runtime {
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ parachains_common::SLOT_DURATION / 2 }>;
  type WeightInfo = ();
 }
 

diff --git a/cumulus/parachains/runtimes/testing/penpal/Cargo.toml b/cumulus/parachains/runtimes/testing/penpal/Cargo.toml
@@ -191,5 +191,3 @@ try-runtime = [
  "polkadot-runtime-common/try-runtime",
  "sp-runtime/try-runtime",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/testing/penpal/src/lib.rs b/cumulus/parachains/runtimes/testing/penpal/src/lib.rs
@@ -582,7 +582,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<false>;
- #[cfg(feature = "experimental")]
  type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
 }
 

diff --git a/cumulus/parachains/runtimes/testing/rococo-parachain/Cargo.toml b/cumulus/parachains/runtimes/testing/rococo-parachain/Cargo.toml
@@ -134,5 +134,3 @@ runtime-benchmarks = [
  "xcm-builder/runtime-benchmarks",
  "xcm-executor/runtime-benchmarks",
 ]
-
-experimental = ["pallet-aura/experimental"]
diff --git a/cumulus/parachains/runtimes/testing/rococo-parachain/src/lib.rs b/cumulus/parachains/runtimes/testing/rococo-parachain/src/lib.rs
@@ -228,10 +228,7 @@ impl pallet_timestamp::Config for Runtime {
  /// A timestamp: milliseconds since the unix epoch.
  type Moment = u64;
  type OnTimestampSet = Aura;
- #[cfg(feature = "experimental")]
  type MinimumPeriod = ConstU64<0>;
- #[cfg(not(feature = "experimental"))]
- type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
  type WeightInfo = ();
 }
 
@@ -594,7 +591,6 @@ impl pallet_aura::Config for Runtime {
  type DisabledValidators = ();
  type MaxAuthorities = ConstU32<100_000>;
  type AllowMultipleBlocksPerSlot = ConstBool<true>;
- #[cfg(feature = "experimental")]
  type SlotDuration = ConstU64<SLOT_DURATION>;
 }