Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IsForeignConcreteAsset Implementation #100

Open
joepetrowski opened this issue Aug 14, 2023 · 0 comments · May be fixed by #2276
Open

Simplify IsForeignConcreteAsset Implementation #100

joepetrowski opened this issue Aug 14, 2023 · 0 comments · May be fixed by #2276

Comments

@joepetrowski
Copy link
Contributor

This is a bit silly, couldn't we just have IsSiblingParachainAsset and call it a day? The code for IsForeignConcreteAsset mostly delegates to the IsForeign type parameter anyway.

Originally posted by @KiChjang in paritytech/cumulus#2842 (comment)

@joepetrowski joepetrowski transferred this issue from paritytech/cumulus Aug 24, 2023
@NachoPal NachoPal linked a pull request Nov 10, 2023 that will close this issue
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
* Bump rust-web3 to latest master

* Use tagged release from crates.io

* Add check for `logs_bloom`

Since this is required by the runtime we want to enforce that an
incoming header has this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant