Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo should only build polkadot by default #1418

Closed
s0me0ne-unkn0wn opened this issue Sep 6, 2023 · 1 comment
Closed

Monorepo should only build polkadot by default #1418

s0me0ne-unkn0wn opened this issue Sep 6, 2023 · 1 comment
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@s0me0ne-unkn0wn
Copy link
Contributor

s0me0ne-unkn0wn commented Sep 6, 2023

Related: #1372

What does a user expect when he runs cargo build -r in the root of the repo? Does he expect malus, xcm-fuzzer, and puppet_worker to be built, as it happens right now? I guess not. Most probably, he wants the Polkadot node software. If he needs to build malus, he better specify that explicitly. Building only Polkadot by default would dramatically decrease build times and improve the UX for those who only want to build the node from sources, which I believe to be the most frequent use case.

The proposal is to introduce default-members in the root manifest to only build polkadot binary and auxiliary worker binaries.

Besides a single-line change in the manifest, that should include proper documentation changes for different use cases of monorepo.

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. label Sep 6, 2023
@s0me0ne-unkn0wn
Copy link
Contributor Author

Done in #1420

serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…aritytech#1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
bkchr pushed a commit that referenced this issue Apr 10, 2024
…1418)

* fix XCM instruction weight in RialtoParachain to match Millau weight

* fix spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

No branches or pull requests

1 participant