Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*NoBound derives should use fully qualified paths #1718

Closed
2 tasks done
benluelo opened this issue Sep 26, 2023 · 0 comments · Fixed by #1763
Closed
2 tasks done

*NoBound derives should use fully qualified paths #1718

benluelo opened this issue Sep 26, 2023 · 0 comments · Fixed by #1763
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@benluelo
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

Since the *NoBound derives don't use fully qualified paths when referring to core (

impl #impl_generics core::cmp::PartialEq for #name #ty_generics #where_clause {
), if there is a module called core in scope it will break.

error[E0433]: failed to resolve: could not find `cmp` in `core`
   --> voyager/src/msg.rs:659:42
    |
659 |     #[derive(DebugNoBound, CloneNoBound, PartialEqNoBound, Serialize, Deserialize)]
    |                                          ^^^^^^^^^^^^^^^^ could not find `cmp` in `core`
    |
    = note: this error originates in the derive macro `PartialEqNoBound` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing one of these items
    |
549 +     use core::cmp;
    |
549 +     use pin_utils::core_reexport::cmp;
    |
549 +     use std::cmp;
    |
help: if you import `cmp`, refer to it directly

Steps to reproduce

No response

@benluelo benluelo added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Sep 26, 2023
bkchr added a commit that referenced this issue Oct 1, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Check origin?

* Removed ensure_signed

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Check origin?

* Removed ensure_signed

* clippy
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Check origin?

* Removed ensure_signed

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant