Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rococo beefy error: BadJustification("Duplicate consensus engine ID") on appending justification #1728

Closed
PierreBesson opened this issue Sep 27, 2023 · 1 comment · Fixed by #1852
Closed

Rococo beefy error: BadJustification("Duplicate consensus engine ID") on appending justification #1728

PierreBesson opened this issue Sep 27, 2023 · 1 comment · Fixed by #1852
Assignees
@acatangiu
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@PierreBesson
Copy link

PierreBesson commented Sep 27, 2023 •
edited
Loading

We are seeing those beefy error logs on all Rococo validators :

2023-09-27 12:03:17.432 ERROR tokio-runtime-worker beefy: 🥩 Error BadJustification("Duplicate consensus engine ID") on appending justification: V1(SignedCommitment { commitment: Commitment { payload: Payload([([109, 104], [187, 14, 3, 19, 80, 125, 51, 46, 42, 59, 190, 61, 0, 135, 58, 22, 51, 132, 226, 39, 58, 6, 197, 81, 216, 23, 21, 84, 136, 95, 12, 35])]), block_number: 7245951, validator_set_id: 12421 }, signatures: [None, Some(Signature(1f004404da0de1c7873fab3b6fa89ea467b081083e6cd162c7ddbd1dace93858798c567e4caef4a904dc740fbd01ef0075b469a42e02a4f70a307436be88f7cd01)), None, None, Some(Signature(18ee2ac46b6c7d9594bc62e0dc15a76a5383bf0c61ebdf4c8a8613763dff04b5017e81cebd0cd9419c45dd34d14e0b4b1edd79eaff0ba9c3a7ba5ff61b26dc0e01)), Some(Signature(3965712e637710099080d8852236ffd09adf0893c8472b67ad5eaf59ff4698cc09ab5da16381de4e63b18edd69870e3a1a4263e3cd4a323c44b9f574c7c5d7a501)), Some(Signature(7ab6ab048249a0bc7dbb56b56508d33f50d2db5f03d735f56d33716ec385c4b12645a021108f40531dd1f50c6ca14b307ed2f948e854d0eccd0cd43e1c62d45600)), Some(Signature(f0c2d5889ded3ac58d7c209cf877670cba4b5264fd210c9e40f44eb8b566e09e145c52a254c86750e029ca4b73803abc8ae72904da9a978993a1cf227448cd1e01)), None, Some(Signature(17dcb43cc9ad747d66ef1a9d35d797f90df9fb2f1f54fe99e5a757e9c2b2af637ec4005d0b5529cdb9500a47690a97e2379c4e49861d941897436165f512fb7600)), None, Some(Signature(0efca76ba0f425fea219afdf084c8bbd88c8b649aa1a223596788b1691fbf1165975fac9a2cc954e76e3247234acf93a876673eb9e92958a869ff7722a0faee300)), Some(Signature(f2e8c04cef4ad84c17abb5db6b0a10daa34d2548402957966d781b603ed2ec9203b9fb86a1757b4f1f7161361306ca1ac709039d2125689f6f580f3cf992eec201)), None, None, Some(Signature(003f1768d7f40127653929a4849791b4c623642204c223dfe12cc4b301a389cb04d051ddaba89b037e89cc97294b2c2072bc519738666d24ad88041c8b5dad4a00)), Some(Signature(b12a65e36056f67b78279569d53d89dee06a1c47f0bcfb8c9f0fd4326d6d41310a530ac6af6b31cfd6d3d774480efd2da1a104ca42d5b81c8ac3cd3814504c7500)), None, None, Some(Signature(d19efd220f15dd5e90247386e652e4ae3f6e5268179ac5b9e0522e88601b16db76ef0a84d45a426ba01e0fb0acac1629bffae034d64f672018a18980e4162aee00)), Some(Signature(82dc1970440b4628ede280a0226b6c76826bbc31e594fdff61feecc1f186a3a957b646e14c8c1f49a1de4e386fada1dd954a1a09bcc4b22dfcfe6a1826fc373300)), Some(Signature(9045a432c858e3e3bb549bf6212c363be778aadaa7058266d5a4b89108f35afe0762f3766a79bc8bebb53ddbce51fd2d93ada7532d85b6d1366c663da54a8f6d01)), None, Some(Signature(35a3ef53ef02cdd767b6e8bc1ea459794c0a0d61068872ce4a1ef3bc98153b9e2266d2d24b79d629bd4c622b779024e35928be2c3a5b13a12505bf64ddb756ba01)), Some(Signature(1357e92317d60428966c791de2ac6ab1ccd486a4b36d0b5dbe74bcd9be199d0c290eec32833fefb6ba527cb0b7ff70830497115029420cf10c32d32eda4f771401)), Some(Signature(3b5ee5e1a4bc3b105842867529d379424279bea931548a8ca2e0bef57bf10d5c15f4274b842ea4dcd19df35a7019761298ff981ff56ddbf1fcb43a9c8598d29100)), Some(Signature(5dac63eccb9e40eab4e828f51085a5dca7407e37c76592582b6925c06aa9e1977092039f300d131d57024ac2c48dfd2536d164036431b7f6264c8ff9495a50ae00)), None, Some(Signature(7eb1277eea8e1d117b9e7a38738d7a2948b2cef0c25e78d0339f4792b6667525740022569b26153e0a7bb1bb0b37851834982aea3b2cf291cfab286740cea21001)), Some(Signature(0f88ae2bda3fe0adf737739dfe4dc1a5de511d442a02bc2047fbfc760f6f8d74536c84202db264db1c2c12d0c2437f2c7bbc2ba3db46b9ee9835e972b5f9365d01)), None, None, None, Some(Signature(c9fe80187f0a2a729deebab038506625881f2908ed7196fa5012c9ab2c57fd026855615a2f6a607e9ea1a38be249ad7f5183160a3f5e8a215362f0193753891500)), Some(Signature(bd0836192a2e668fdf3d8831d9e2497883c2ed94b9863b4cff70ab323acd64c20e24234342d7635b6f8066ba4bbe274a1ddcafb2cd0bf3fb67acd9f0cef880b701)), None, None, Some(Signature(53e3a824cdfdfd0b7986a94fb7a8e65933dcf3737e7b41bc963fdb3079fefc326213717a54f0aa240eb955bb209873dacbfc41482d2982855da2f57b83e5343400)), Some(Signature(8d4a8696fce1def8b26a8185bc0ae78b1779433eb7e9d4cb1077a9db9fa25e3c40aaecbfbdb65608589c3ddd8e4c7808fee02e3056f0d2ee9f54a8774c3c7e6d01)), Some(Signature(d6263b2408ad76652f91a0dc765fb22b7d7a3219f5007ce40ddc8af11bc4d94417c13ce8f567e18a1b0692ed4ad134456dad0e1db82848a64987fc7380325b6100)), Some(Signature(d42d08aeb75ff1813511d37f0634d47d0eeab2dff9d754052dc54d912cf24885403b868593676af7590a84145ba136bde0b23d49538008ee659abed193b985d300)), Some(Signature(25ca12d7fcb5aeea6dba8898c3231feaf9b8611eaa617b098c5e32e44d6ad9b97c268f52f5ced6286457c64b36e0e581191ff9759967037dbd8299677861cd0d01)), None, Some(Signature(6ba37b571d0f3e0bbf838d66417192884b86a8cb9933804aa55a0738ff9e26b81b748529cd952624727ff4a07b255569ee91468d29546f792c01c139026bdeec00)), Some(Signature(d34b50a938444067fe19f94b6f6b490515b3aa98c9d4bde455d46c65980f12d374a844dfa874a8ec7c9d7af8169673a131630645481cae0abe5b2af52313b39200)), None, Some(Signature(f92f2a85da359b30a21764ea55ae458f83ffe8c0daf2e9fd91c3a4ea6348286d5f246a18b273947f7811bcde2d6dbb0e040ce5328688cf26231b94d5d6dbd3a900)), Some(Signature(2fb993aa6889cc88b878e15250810484f735c4f0ca194214c3c9da798d71807755e0e7e83a743719ed0f4ede7f8875b1d160b49bdeedc5df32abac98a779da3a01)), None, Some(Signature(add2dda3d08624b3d638966987da07dbbec9fd95185db3a73cdb5049df45cabf316cf314dd46ee440e6f4a1089f1aa7d527aa3a0b2c2771de58358cb96daa84b00)), Some(Signature(e802d47c9eaaa69d1a9fd66f18541293a3880e8a5fcfff5a0f70aafcdc4b450e3f17f6c9ec036e00e0be0296c9c97f4995629194d989a4e50005ee0937fdb46601)), None, Some(Signature(58d9df342c01bbe13ad05b08c2ab5bd4ec48d7b60b8ba4f27e951bf218cfed9618b349e6503f94c1b4cc8e1602bfc8b07313c64f7b0e0976845434457a5b749e00)), Some(Signature(6df5f4098213f4ddc95f674b78dd23dd730435f28202aa0dd3adfd1ffa3e9e7e4172ce07789ad6409ac130e5022e5607c525f0d0fe257cb74d82f193e973756300)), None, Some(Signature(57af4f0cf8bcc499e20d31372f13fa31e33cf87e9e90616d9300714a8056f44770b8f26113f56370fa57eeb6ef48c34a4a4faef66d27e97d74432ed683638bb201)), Some(Signature(d3be560ccf75525c20ba7b98b4499a47ccd2a861835aec32b0c09650c06aae42454560c3391f66dcaaddcd7f6d92b9a32ffe4482dc4de5c9b84ce5b0dcad75a001)), Some(Signature(d2aa168bee683d49ee3d8d0cba0cb8956afbc1ff1a9760acc74bb392f85402977bed40ded477fdcc5c844c9cf781612fcc6ee29bcca867fc55409397b79a049301)), Some(Signature(47dd24a1df6c5950783af27ac6214dee7af0bda7cd18c494b40b16b1aae6e8701bf3cfa2478fcb77b29e0bcc423bcf46142f9727c7194c6fb84ba2fd1e93e8f401)), Some(Signature(f700ae84b26bc2612e095de94871d7506cca7d445a1090b1ff65c4d395a8c0c949eb93325e86bbad449da51595498f7302c30e7373c0c7752c5721f1958f0dbd00)), None, Some(Signature(931da2bada4bacceb435e8fc79c348ab56765c87e5d13aabd4ad977c1562b0105ef63c7efa0abf7a0fdfd641c20d3e981b815753cc276cd98d9b9c518dcaf29b01)), Some(Signature(bf066b7dd57ff8ba9aa628cabaac037dac827ffb7f6a77e01c714139812c195b39fd154bd599ecda5861b1244d6d39ee7a2a05f6e8a5182e6fbd80b78a86bcff01)), Some(Signature(3b5edcd0fc2ca58db8b8bfecc4668a308d56f1680e5519fbb7f4c0873d3511ba1ec0a7b606197d35d0878baa7b0dd046d47e36b2182da8672583d746cea381b800)), None, Some(Signature(bcc4b2fbf611aadc22a049bc0466d86ad87d9207f1a50ba6f4bb6ece15461272713ae500d7e3c14e20e2f0107b25ca7e413b6ca4bae4f0d6537e87d251f052d801)), Some(Signature(2c78445681236c3fce482e8c56a621ef1f4049c3ef205506af2ec5e7f7ebe6b342b14ae3783847a1fba123076797046eba212156379fd6bdb2a49d0aca273f7301)), Some(Signature(5b343580af4e1efceb30d705492a64ce6f3e00dd35247d5a748242f84d1017a36aa73a374b731efe7e813f7309645370710019aab690241e912dc3cd06e80bc900)), Some(Signature(c1f8948a761232dabe5f021af2dd4a17e431a2fa5b7e24f4a7e3c0edb905127359ba0f9dcde283f32c79f22d33c2f3f0e13f1caf728e182b7181f74a007bc5eb01)), Some(Signature(6f860aa5db39a7022bb6af5cefcd3fd4c73043ffa156fef2087f701891901e6f1ebca070464ca12cb029a292c7424dbb5c11de7dbe60886d61834abd2cddc85f01)), Some(Signature(21231461c359ddf76d4681c82c0146e79b31039e138c742c806a252513e14ba572a8a4e3ba2fcbbbcf0d7024eebd532fcc3ea003771cad4899625cfd7af65cf700)), Some(Signature(06955ceda2a6bc851862547c8aa9a6325b83adb30b66819be843561bdc1c0d104ba7e6b78a6cea89afad811ed86f748159fd52d3078f94e156232cc3d8057a9101)), Some(Signature(bf7ca96a26da4b245a8d478b06fd23719a313b4b299a60133c5a281b1e24fb6d2719e14bc06ab41856acf1173f6be734545dc8ad91e3fa8827e47f4e597efc3901)), Some(Signature(72f9e070f88d205126ae991c3b2f9ab4e410314cf0eaf756731bf8f7e2868ba802449b8e2b06d1464d1d960e868d45924b68f9107911022501aff0dbd42d2a8a00)), Some(Signature(dde7c5ce40f39eab9ec8d59f63f57ab290498da28bbeb2c0cd5410b4f8d8365f535b72fca64675b9824004210c3fcc28d7f471d4177cb1a66017346ab38b30c401)), Some(Signature(086f59fbb58ccf5028447f33041ae1bacf8b3a49820d89b41a9dde19d95201c65f13d3c841daab0a0823cc53012a7c9cb86a2d14e6274bc1c2ce76e68f5101bb00)), Some(Signature(9ee53e9dcbbe5be5cbbe21f525b79e4d963a6c5e5fbbe1f33daa79a9c8786651089405507921bd4ba6b0175f0fca38228f70c907eac51aa4902f4f273b478a5f00)), Some(Signature(b7367591667222b10959086460338559d3ac1fb8376b312b40637d1fa2dbd917246118841be9ed8a86b95a0ad1df92c976f34bde8b79c8d59b80e151fd4538d100)), Some(Signature(b2c171b0866b0f5f731c26b18bf9497574529696d95e659b643ff910b3ab87260fd4be87f710dc2433ef10a4387bf7025b581fd4979e168110bc71e063be4a1501)), Some(Signature(7dd5ea21a09b65b61b82b81e180d99b7af77929ca9759962217aaa5bee35884f6466ce66acce083f81c382558d93b7ad5e9e641aa0c3c981b29ca2c22762cc0a00)), Some(Signature(66388222fc8ac46a0f2d9cd8f738cbf5d97b3268a386918e35f20d29b724099149a3561ab880f44659bc40c9f339b4cdba9f1580b3970ae92c5e4a033569c94901)), Some(Signature(856480c069df75d49c64f5e21d925a672e3be7c274ce12be649ab550ffe0d0a204558d4db4ed96f42ee91bc2a4e9eb55578452b9d82278941f3959abce2eef6101)), Some(Signature(51c9078d793c7e56198dc00880cfb71f3dd6cd96866de0a74be8aedba75a6fe0782fb58b8d193d86821c0304f2a3fc09463f06c16a0f54bb17751c849f4a297500)), Some(Signature(4869cec4e9167d5788d779414797784d15265aaf3ea5fa0d11084cced8548c6b19938ff9b5b41b94818ebcd8a29d9482783759391b83f6a000fa286a6b21f14101)), None, Some(Signature(a4eff3914bb4964f0d9a8072a7a29b8cd819fa1fbb897c9b67c915a23a2dd4d9101ce3bc38757f23dcc4c7c15af253e16e0fc40b71962e54291a8b60df4a3e6f01)), Some(Signature(48615fbd52dcb446d0dd959f4896d2a180166c83b3fe3e2d5c9e1cccbe7891a80802001e19032043eb45354da169c87c95c643927b0164ce7566049ebe99c06401)), Some(Signature(83843d6a4f5465a25d29dce26bb55adc7e84f6e64bd54727110b815ca24b414179d6ce5c0b3aedc57004fd3ca8cd0eb1e902de09feadb63a48bf9e9b2fbafe8900)), Some(Signature(a82838b05772b415f2532ca59646a9a23775019d068e4efa7de5ec21275a3a0a49e20ebb7631988045e45a8f31bb5397a043be0e8ff87224bd1604d683557b9c00)), Some(Signature(5bee26848a7a2ab0285da114bf75f5f69cdfb9d897a3dccdcd72f3f5fa0df9964327ab98ca1a263b96fa2bee6b4ae51bfcc359a515e7c5fced5cc498ed3d940f00)), Some(Signature(fda3098dfde921ba62c0372bb1a46f395e2809c1f28c28f2b9379602b3da2c97623b5d5346f5d799537f8910fd33ab55ae9bbaa3426f63cface7dc15d521283f00)), Some(Signature(cdf72acf769288ab550806f376a9c696333911b20e9478a9dce7bb006e174f8a4d16de9b44888a870cc5742dec5047d493543a5e0b6c04a34578b14e07276c4800)), Some(Signature(0113504c18085b1b168c673977c4e5a4a7d11e37013b83a860a91ea223a8815c7894e4b2d42684c872a392825760939da0028864b11645e9c2e50062862690aa00)), None, Some(Signature(66fb0f77904152217aee35b911fb0182b4feec545a1c9a8782ef933e227a4d6969d51f9823505fe121ffd24f4bc612b0270e74669f663b932dd378713ade7a3c00)), None, None, None, Some(Signature(c8065ce6a413b3500b5a77667a693794a737ae91bd06e814c512003904a88d3e2b3487f70bf723dbdcf4adab6d41b654f6bf34d7658c4c235718e8c3a043229700)), Some(Signature(f91a89437a5c3135c5f28eed55b24b9f9d92a8db01f665bf05383182014c53de73df6dc14cb5dad4f908314a212eabfea235034d1bc191cf6bfebbf5f142be4601)), Some(Signature(c0c0a4606370aa0198b78fe8708ad929ae1beb94328747e7f0e924862243e568165ba3a63ec8d23530e4eec7ce8083ec13eeaeb3ff2c2ee89e32b245f1ea0de100)), Some(Signature(9d412efb97647046c23b37832299e4007561af9ccfe7e1ced39340fca4552e6900487568154f59348dddcb21a2e9eb2f734ece3a116cc3b4019ceb5f5f4c1ce400)), None, None, None, None, None, None, None, None, Some(Signature(fd128342516de1ef24a1d1636f5ceeb96abbf63d3430b1f45f76b3941ab36aa6636ba275b826bc4eccc7d448ab1aaa9180d77c7921b8e1aa09bb082d9ea51a5001))] }) |  

@acatangiu
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Sep 27, 2023
@acatangiu acatangiu self-assigned this Sep 27, 2023
@acatangiu acatangiu added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I10-unconfirmed Issue might be valid, but it's not yet known. labels Oct 11, 2023
@acatangiu acatangiu mentioned this issue Oct 11, 2023
Merged
@acatangiu
Copy link
Contributor

This is not an actual issue, but it is a distracting annoyance. Opened #1852 to fix it and also improve the protocol usage a bit.

acatangiu added a commit that referenced this issue Oct 13, 2023
@acatangiu
sc-consensus-beefy: improve gossip logic (#1852)
8320600 
- Remove cached messages used for deduplication in `GossipValidator`
since they're already deduplicated in upper layer `NetworkGossip`.
- Add cache for "justified rounds" to quickly discard any further (even
if potentially different) justifications at the gossip level, once a
valid one (for a respective round) is submitted to the worker.
- Add short-circuit in worker `finalize()` method to not attempt to
finalize same block multiple times (for example when we get
justifications for same block from multiple components like
block-import, gossip or on-demand).
- Change a test which had A LOT of latency in syncing blocks for some
weird reason and would only run after ~150seconds. It now runs
instantly.

Fixes #1728
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@acatangiu
sc-consensus-beefy: improve gossip logic (paritytech#1852)
0e01998 
- Remove cached messages used for deduplication in `GossipValidator`
since they're already deduplicated in upper layer `NetworkGossip`.
- Add cache for "justified rounds" to quickly discard any further (even
if potentially different) justifications at the gossip level, once a
valid one (for a respective round) is submitted to the worker.
- Add short-circuit in worker `finalize()` method to not attempt to
finalize same block multiple times (for example when we get
justifications for same block from multiple components like
block-import, gossip or on-demand).
- Change a test which had A LOT of latency in syncing blocks for some
weird reason and would only run after ~150seconds. It now runs
instantly.

Fixes paritytech#1728
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
remove messages pallet owner relay argument (#1728)
b51da64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acatangiu acatangiu

Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sc-consensus-beefy: improve gossip logic acatangiu/polkadot-sdk
2 participants
@PierreBesson @acatangiu