Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Rococo Parachains Stuck #1923

Closed
boundless-forest opened this issue Oct 18, 2023 · 3 comments · Fixed by #1920
Closed

Some Rococo Parachains Stuck #1923

boundless-forest opened this issue Oct 18, 2023 · 3 comments · Fixed by #1920
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@boundless-forest
Copy link
Contributor

Most of the parachains(except the BridgeHub and AssetHub) under the Rococo are stuck as shown in the pictures below. Any ideas?

image

image

image
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Oct 18, 2023
@eskimor
Copy link
Member

eskimor commented Oct 18, 2023

Asynchronous Backing was enabled on Rococo. Old collators will still speak the old protocol, which gets rejected by validators after async backing was enabled. We can and want to be actually more lenient. Expect this to be fixed today.

@eskimor
Copy link
Member

eskimor commented Oct 18, 2023

Fixed by: #1920

@NachoPal NachoPal mentioned this issue Oct 18, 2023
Closed
@bkchr bkchr mentioned this issue Oct 18, 2023
Merged
@acatangiu
Copy link
Contributor

acatangiu commented Oct 18, 2023 •
edited
Loading

Fixed by: #1920

In the meantime (before ^ is merged + released), parachains can be unblocked by upgrading collators to https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.2.0

L.E. Actually, looks like the fix will be patch-deployed to Rococo validators directly so no need to update collators to unblock.

bkchr added a commit that referenced this issue Oct 19, 2023
@bkchr @eskimor
Do not force collators to update after enabling async backing (#1920)
b967ba5 
The validators are checking if async backing is enabled by checking the
version of the runtime api. If the runtime api is upgraded by a runtime
upgrade, the validators start to also enable the async backing logic.
However, just because async backing is enabled, it doesn't mean that all
collators and parachain runtimes have upgraded. This pull request fixes
an issue about advertising collations to the relay chain when it has
async backing enabled, but the collator is still using the old
networking protocol. The implementation is actually backwards compatible
as we can not expect that everyone directly upgrades. However, the
collation advertisement logic was requiring V2 networking messages after
async backing was enabled, which was wrong. This is now fixed by this
pull request.

Closes: #1923

---------

Co-authored-by: eskimor <eskimor@users.noreply.github.com>
tdimitrov pushed a commit that referenced this issue Oct 23, 2023
@bkchr @eskimor @tdimitrov
Do not force collators to update after enabling async backing (#1920)
d03a54d 
The validators are checking if async backing is enabled by checking the
version of the runtime api. If the runtime api is upgraded by a runtime
upgrade, the validators start to also enable the async backing logic.
However, just because async backing is enabled, it doesn't mean that all
collators and parachain runtimes have upgraded. This pull request fixes
an issue about advertising collations to the relay chain when it has
async backing enabled, but the collator is still using the old
networking protocol. The implementation is actually backwards compatible
as we can not expect that everyone directly upgrades. However, the
collation advertisement logic was requiring V2 networking messages after
async backing was enabled, which was wrong. This is now fixed by this
pull request.

Closes: #1923

---------

Co-authored-by: eskimor <eskimor@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
Verify with-parachain message benchmarks on CI (paritytech#1923)
66d200a 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
Verify with-parachain message benchmarks on CI (paritytech#1923)
f5e8747 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
Verify with-parachain message benchmarks on CI (paritytech#1923)
3385e43 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
d0b7746 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
21b6254 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
900a830 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
cd58fc7 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
299fe74 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
1ae497f 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
c9b7eef 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
dc20cf3 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
6fe5666 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
5a715b0 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
0ed818b 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Verify with-parachain message benchmarks on CI (paritytech#1923)
a327ec4 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Verify with-parachain message benchmarks on CI (#1923)
ddbeab7 
* verify with-parachain message benchmarks on CI

* trigger CI

* Revert "trigger CI"

This reverts commit 188cd01563bc8b3537d042c6c8d5181b7cfcdac8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not force collators to update after enabling async backing paritytech/polkadot-sdk
3 participants
@eskimor @boundless-forest @acatangiu