Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defensive! testing extrinsic #1953

Closed
ggwpez opened this issue Oct 20, 2023 · 3 comments · Fixed by #1998
Closed

defensive! testing extrinsic #1953

ggwpez opened this issue Oct 20, 2023 · 3 comments · Fixed by #1998
Assignees
@adelarja
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 20, 2023

I think we should extend the RootTesting pallet with a trigger_defensive call that can be used to check that the runtime monitoring for our networks works end-to-end.
This could then be deployed to Rococo/Westend and called by devops to test it.
@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Oct 20, 2023
@ggwpez ggwpez added the C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. label Oct 20, 2023
@adelarja
Copy link
Contributor

@ggwpez, I can take it if no problem.

Just to clarify, is the only idea behind the trigger_defensive call for use by the devops team for testing purposes? Would it be a good idea for us to dispatch an event for this?

@ggwpez
Copy link
Member Author

ggwpez commented Oct 21, 2023

Just to clarify, is the only idea behind the trigger_defensive call for use by the devops team for testing purposes? Would it be a good idea for us to dispatch an event for this?

Yea, event sounds good as well.

@adelarja adelarja mentioned this issue Oct 24, 2023
Merged
4 tasks
@adelarja
Copy link
Contributor

adelarja commented Oct 24, 2023 •
edited
Loading

@ggwpez I've opened a WIP PR. I've tested it locally, and I only need to improve the code quality a little bit. Please let me know if you have any comments.

ggwpez added a commit that referenced this issue Oct 31, 2023
@adelarja @ggwpez
1953 defensive testing extrinsic (#1998)
6e2f94f 
# Description

The `trigger_defensive` call has been added to the `root-testing`
pallet. The idea is to have this pallet running on `Rococo/Westend` and
use it to verify if the runtime monitoring works end-to-end.

To accomplish this, `trigger_defensive` dispatches an event when it is
called.

Closes #1953

# Checklist

- [x] My PR includes a detailed description as outlined in the
"Description" section above
- [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
of this project (at minimum one label for `T`
  required)
- [ ] I have made corresponding changes to the documentation (if
applicable)
- [ ] I have added tests that prove my fix is effective or that my
feature works (if applicable)

You can remove the "Checklist" section once all have been checked. Thank
you for your contribution!

✄
-----------------------------------------------------------------------------

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Oct 31, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@adelarja @ggwpez
1953 defensive testing extrinsic (paritytech#1998)
a175f84 
# Description

The `trigger_defensive` call has been added to the `root-testing`
pallet. The idea is to have this pallet running on `Rococo/Westend` and
use it to verify if the runtime monitoring works end-to-end.

To accomplish this, `trigger_defensive` dispatches an event when it is
called.

Closes paritytech#1953

# Checklist

- [x] My PR includes a detailed description as outlined in the
"Description" section above
- [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
of this project (at minimum one label for `T`
  required)
- [ ] I have made corresponding changes to the documentation (if
applicable)
- [ ] I have added tests that prove my fix is effective or that my
feature works (if applicable)

You can remove the "Checklist" section once all have been checked. Thank
you for your contribution!

✄
-----------------------------------------------------------------------------

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adelarja adelarja

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add defensive testing extrinsic adelarja/polkadot-sdk
2 participants
@ggwpez @adelarja