Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVF validation host: hook up heads up signal #2341

Open
pepyakin opened this issue Apr 9, 2021 · 1 comment
Open

PVF validation host: hook up heads up signal #2341

pepyakin opened this issue Apr 9, 2021 · 1 comment
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Apr 9, 2021

The new PVF validation host allows its client, candidate validation, to inform about soon needed PVFs via a so called "heads up" signal.

Candidate validation subsystem should periodically collect all active PVFs' code hashes and pass it to the PVF validation host. The interval doesn't matter that much from standpoint of PVF validation host, but from a glance it makes sense to do this once every session.

It would be good to have #973 first, so that we don't have to shoot validation code preimages. Also we must have a way to query "relevant" PVFs from the paras module in the runtime.

Update 2021-08-09: This should take into account that with paritytech/polkadot#3211 we will no longer be able to just reuse the results of low-priority compilation. Therefore, either we redo the compilation to get proper results for the pre-checking game or we just ditch lower priority compilation and always approach preparation as if it was for the pre-checking game.

@burdges
Copy link

burdges commented Apr 9, 2021

I mentioned availability reconstruction of code in #973 but again like with blocks do feel free to optimize by fetching the full code fro anyone who possesses it. If we construct that system before the availability reconstruction part then we need to be able to adequately test the availability reconstruction part whenever we eventually write it.

@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot Nov 15, 2023
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Nov 15, 2023
@the-right-joyce the-right-joyce added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. and removed I10-unconfirmed Issue might be valid, but it's not yet known. labels Nov 15, 2023
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…aritytech#2341)

* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Move finality Engine to finality_base folder

* Define SubstrateFinalityPipeline

Extract basic parts of SubstrateFinalitySyncPipeline into
SubstrateFinalityPipeline

* Add equivocation detection pipeline

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants