Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core time: Kusama #2353

Closed
9 of 13 tasks
eskimor opened this issue Nov 15, 2023 · 6 comments
Closed
9 of 13 tasks

Core time: Kusama #2353

eskimor opened this issue Nov 15, 2023 · 6 comments
Assignees

Comments

@eskimor
Copy link
Member

eskimor commented Nov 15, 2023

Checklist will be based on the one of Westend.

Migration legacy -> legacy + bulk - no on-demand was existing before.

  • coretime chain was registered as legacy parachain
  • no ongoing auctions - after we migrated to coretime no new lease holding parachains must come into existence. (Covered in migration - we cancel + refund)

Added from Rococo checklist:

  • coretime chain is running
  • Limits are high enough for migrations to succeed?
  • Weight limit is higher than actual weights (as benchmarked), but low enough to fit in a block?
  • Configure Kusama parachain lease length?
  • Motion: Launch coretime chain with 1.2 runtime
  • Motion: relay chain runtime upgrade
  • Ping community that coretime has launched and that they can buy core time now with their KSM, to keep their chains running.
  • Motion: start_sales: Pass in proper last_sale configuration to have sales start at the proper time.
  • Motion: call request_core_count with the desired amount of cores (expring + any new ones + 1 for on-demand). Setting limit_cores_offered configuration seems redundant/error prone.
  • Motion: Assign one reserved on-demand core

Actual motion used on Kusama: https://kusama.subsquare.io/referenda/375

Prepared: https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fkusama-rpc.dwellir.com#/extrinsics/decode/0x630003000100b50f03142f0000060202ca9a3b01107c32000a000000e0c40000e0c40000b013000000ca9a3b0080c3c901b01300000602fa5159b0017d10321234000602c2c33f4612a6010038320104ffffffffffffffffffff010602071ecddf380322b70100503204005039278c04000000000000000000003400

Discovered while implementing runtime:

  • Dependency of polkadot-runtime-parachains > 6.0.0 (missing coretime modules) met
@eskimor eskimor converted this from a draft issue Nov 15, 2023
@eskimor eskimor moved this from Backlog to In Progress in parachains team board Jan 18, 2024
@eskimor eskimor mentioned this issue Feb 13, 2024
3 tasks
@eskimor eskimor mentioned this issue Feb 20, 2024
6 tasks
@JelliedOwl
Copy link

"no ongoing auctions - after we migrated to coretime no new lease holding parachains must come into existence."

Does this mean that, once coretime arrives, it's no longer possible to register a new paraid and swap an existing lease to it?

@liamaharon
Copy link
Contributor

Should this issue be migrated to the fellowship runtimes repo?

@bkchr
Copy link
Member

bkchr commented Feb 24, 2024

Does this mean that, once coretime arrives, it's no longer possible to register a new paraid and swap an existing lease to it?

Swapping leases is a concept that doesn't exist with coretime anymore. So, yes you will not be able to do this.

@JelliedOwl
Copy link

Swapping leases is a concept that doesn't exist with coretime anymore. So, yes you will not be able to do this.

Thanks Basti. So even for teams that have legacy leases - no swap mechanism from day one of coretime even if they have legacy lease time left that they want to move?

@bkchr
Copy link
Member

bkchr commented Feb 24, 2024

So even for teams that have legacy leases - no swap mechanism from day one of coretime even if they have legacy lease time left that they want to move?

That is actually something we did not thought about to be honest. I mean all leases are migrated and they are not "lost". So, if you currently have a lease for X months, you will still get this. However, you will not be able to swap them. I assume you want to swap some lease?

I personally would be open to fast track this through fellowship, for the small number of projects that already acquired a lease. But maybe we can get them to swap before. I will ensure that this doesn't get lost and we have "a way" forward.

@JelliedOwl
Copy link

Thanks @bkchr.

To be honest, I'm considering speculatively picking up a cheap lease before coretime arrives, for a project that might or might not happen. I'm interesting in whether I would be able to off-load it to another team if I ended up not needing it, but it might be something that happens 1 or 0 times, so "fast track this through fellowship" is probably the right way to handle it.

I know some current teams are still buying leases on new paraids and swapping them rather than just extending their existing lease (I'm not sure why, but maybe they want the extra bidding power of that extra few lease periods in their bid), so there could be a team that does this right at the end of the auctions and doesn't swap it in time. Most likely not though.

serban300 added a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
serban300 added a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
… (paritytech#2353)

* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Split FinalitySyncPipeline and SourceClient

* Move some logic to finality_base

* Add empty equivocation detection clients

* Add equivocation reporting logic to the source client

* Use convenience trait for SubstrateFinalitySyncPipeline

* Define JustificationVerificationContext for GRANDPA

* Equivocation source client: finality_verification_context()

* Equivocation source client: synced_headers_finality_info()

* reuse HeaderFinalityInfo

* Define EquivocationsFinder

* Fix spellcheck

* Address review comments

* Avoid equivocations lookup errors
@eskimor eskimor moved this from In Progress to Completed in parachains team board May 15, 2024
@eskimor eskimor closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

No branches or pull requests

5 participants