Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orchestra-proc-macro warning in build log #2836

Closed
ggwpez opened this issue Jan 2, 2024 · 0 comments · Fixed by #2848
Closed

orchestra-proc-macro warning in build log #2836

ggwpez opened this issue Jan 2, 2024 · 0 comments · Fixed by #2848
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@ggwpez
Copy link
Member

ggwpez commented Jan 2, 2024

Seeing a log of these recently (also in the CI https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4827444):

[orchestra-proc-macro-0.3.3/src/graph.rs:207] err_msg = "Expected value after assignment"
Hetscher/Hiccup: Failed to parse dotfile
caused by: Expected value after assignment
expander: writing orchestra-expansion-c5de4377c228.rs

Dont know how bad that is, but the build and clippy still work.
@ggwpez ggwpez added the I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. label Jan 2, 2024
@bkchr bkchr mentioned this issue Jan 4, 2024
Merged
@sandreim sandreim mentioned this issue Jan 4, 2024
Open
bkchr added a commit that referenced this issue Jan 4, 2024
@bkchr
Remove dotgraph feature (#2848)
5b9e69d 
Apparently the implementation is broken and is generating warnings in
the build. Not sure this was used any way by anyone.

Closes: #2836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dotgraph feature paritytech/polkadot-sdk
1 participant
@ggwpez