Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the bridges zombienet tests in the CI #3176

Open
serban300 opened this issue Feb 1, 2024 · 6 comments
Open

Run the bridges zombienet tests in the CI #3176

serban300 opened this issue Feb 1, 2024 · 6 comments
Assignees
Labels
T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.

Comments

@serban300
Copy link
Contributor

Right now we can't run the bridges zombienet tests in the CI.

More details on the issues we encountered:

We think the issues are related to the fact that our setup is pretty demanding and that we were running it completely inside the test container.

We should try to fix this. The first option that comes to mind is to try to run each zombienet inside kubernetes.

@serban300 serban300 added T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges. labels Feb 1, 2024
@serban300 serban300 self-assigned this Feb 1, 2024
@pepoviola
Copy link
Contributor

Hi @serban300, this is a good use-case for zombienet v2. We are currently working on k8s provider and we can help with this issue.
Thx!

@serban300
Copy link
Contributor Author

Hi @pepoviola ! Thanks ! How could we find out more about zombienet v2 and what use cases it can support ? Is there a repo ? Are there any docs ?

@serban300
Copy link
Contributor Author

The issues don't seem related to high load and running in kubernetes doesn't help. The problem is that we get incorrect "error" reports when we execute the bridge init transactions because of #3204. Will try to ignore the errors as a workaround.

@pepoviola
Copy link
Contributor

Hey @serban300, sorry about the delay.

Will try to ignore the errors as a workaround.

Sounds good, let me know if you need help with that.

Just for reference the new version of zombienet is being develop in this repo.

Thx!

@serban300
Copy link
Contributor Author

Thanks @pepoviola ! Will take a look on the repo the following days.

github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
Related to #3176

This PR only adds the first bridge zombienet test back to the CI after
fixing it, reverting
#3071

Credits to @svyatonik for building all the CI infrastructure around
this.
@serban300
Copy link
Contributor Author

serban300 commented Aug 21, 2024

The zombienet tests that this issues was about have been added to the CI in the meanwhile and they are running successfully. Leaving this issue open just to keep track of one more thing:

  • There is another test that was added later and that doesn't work: 0003-required-headers-synced-while-active . We didn't add it to the CI, but it is in the repo. We should either fix it run it in the CI or delete it.

github-merge-queue bot pushed a commit that referenced this issue Aug 28, 2024
Related to: #3176

This PR:
- migrates test 0003 to the new bridges zombienet tests command
**This test didn't work before and it still doesn't work. It was added
at a time when we couldn't run it because we didn't have the scafolding.
It needs to be fixed. For the moment we keep it in the repo as it is
since the idea has value. But we don't run it in the CI. We can also
decide to remove it in the future**
- removes the old command for running bridge zombienet tests
- updates the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.
Projects
Status: Todo
Development

No branches or pull requests

2 participants