Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_rank() method in RankedMember trait #3315

Closed
2 tasks done
Doordashcon opened this issue Feb 14, 2024 · 1 comment · Fixed by #3393
Closed
2 tasks done

Add max_rank() method in RankedMember trait #3315

Doordashcon opened this issue Feb 14, 2024 · 1 comment · Fixed by #3393
Labels
I5-enhancement An additional feature request.

Comments

@Doordashcon
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

currently working on adding the try-state hook to pallet-core-fellowship, we set the maximum ranked member count to be a constant 9(i.e. const RANK_COUNT: usize = 9;), I suspect as new collectives get added this would not be the case.

Request

/// Ranked membership data structure.
pub trait RankedMembers {
	...

	/// The maximum rank possible in this membership organisation.
	fn max_rank() -> Self::Rank;
}

Solution

No response

Are you willing to help with this request?

Yes!

@Doordashcon Doordashcon added the I5-enhancement An additional feature request. label Feb 14, 2024
@bkchr
Copy link
Member

bkchr commented Feb 14, 2024

Sounds reasonable.

github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
resolves #3315

---------

Co-authored-by: doordashcon <jessechejieh@doordashcon.local>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
resolves paritytech#3315

---------

Co-authored-by: doordashcon <jessechejieh@doordashcon.local>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
resolves paritytech#3315

---------

Co-authored-by: doordashcon <jessechejieh@doordashcon.local>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants