Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pallet-xcm / pallet-xcm-benchmarks] Improvements #3470

Open
8 tasks
bkontur opened this issue Feb 23, 2024 · 2 comments
Open
8 tasks

[pallet-xcm / pallet-xcm-benchmarks] Improvements #3470

bkontur opened this issue Feb 23, 2024 · 2 comments
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@bkontur
Copy link
Contributor

bkontur commented Feb 23, 2024

Relates to: #3464

TODO

  • remove usage Currency trait from pallet-xcm / pallet-xcm-benchmarks
  • remove usage of pallet_balances from benchmarks and replace with something generic e.g. AssetTransactor or pallet-xcm-benchmarks uses type TransactAsset: frame_support::traits::fungible::Mutate<Self::AccountId>
  • pallet_xcm change Currency trait to fungible see type Currency: LockableCurrency
  • fix // TODO: correct weights. in on_initialize for VersionDiscoveryQueue
  • check set_up_complex_asset_transfer and DeliveryHelper
  • move xcm_sender stuff from polkadot-runtime-common somewhere else (and then remove dependency from parachain-system)
  • do not use ED as a transferable amount, better some "random" value
  • return back verify for teleport_assets which was removed here XCM coretime region transfers #3455
@Szegoo
Copy link
Contributor

Szegoo commented Feb 27, 2024

#3455 Resolves some of the todos.

muraca added a commit to muraca/polkadot-sdk that referenced this issue Mar 18, 2024
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@acatangiu acatangiu moved this from Draft to Backlog in Parity Roadmap Mar 28, 2024
@bkontur
Copy link
Contributor Author

bkontur commented Apr 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants