Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRAME] Run benchmark tests with real Runtimes #3555

Open
ggwpez opened this issue Mar 3, 2024 · 1 comment
Open

[FRAME] Run benchmark tests with real Runtimes #3555

ggwpez opened this issue Mar 3, 2024 · 1 comment
Labels
I5-enhancement An additional feature request. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 3, 2024

Currently we run the benchmark tests only with mocked runtimes. This necessitates an additional CI check that does a bench run with the actual runtimes.
Now with the genesis builder API we can extend the auto generated benchmark tests to also run with the real runtimes. Could be done as part of the define_benchmarks! macro in the runtime.

Depends on #3512 (dont want merge conflicts with that).

@ggwpez ggwpez added I5-enhancement An additional feature request. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Mar 3, 2024
@ntn-x2
Copy link

ntn-x2 commented Sep 16, 2024

I was just trying to implement the same thing for our runtimes, and found myself down a rabbit hole. So I 100% agree this is definitely a nice thing to have.

ntn-x2 added a commit to KILTprotocol/kilt-node that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Development

No branches or pull requests

2 participants