Use Verify::Signer for the offchain SigningTypes trait definition
#357
Labels
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
D0-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder.
I4-refactor
Code needs refactoring.
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
Comments
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is this issue still open for contributions? @kianenigma @rakanalh @shawntabrizi |
the-right-joyce
added
I4-refactor
claravanstaden
pushed a commit
to Snowfork/polkadot-sdk
that referenced
this issue
Dec 8, 2023
* first draft of parachain commitment relayer * refactor updates * rename * first attempt * more refactor * fix * sub to headers * start test * pr fixes * useful mage command * log improvements * remove * fix * fix * main commit * remove unused
jonathanudd
pushed a commit
to jonathanudd/polkadot-sdk
that referenced
this issue
Apr 10, 2024
paritytech#357) * extracted relay crates * moved metrics to utils * exchange-relay compilation * fix compilation of headers-relay * fixed messages-relay compilation * fixed ethereum-poa-relay compilation * cargo lock * cargo fmt --all * clippy * cargo fmt --all * fix tests compilation * clippy * eof * module level docs * removed obsolete comment * #![warn(missing_docs)] * .0 -> Deref * post-merge fix * cargo fmt * Update relays/headers-relay/src/headers.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Update relays/headers-relay/src/headers.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Update relays/headers-relay/src/lib.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a follow up to the refactoring of paritytech/substrate#5182, Implementing
SigningTypescould be simplified to just specify theSignaturetype whilePubliccan be defined as<T::Signature as traits::Verify>::Signerhttps://github.com/paritytech/substrate/blob/4a6d2686e7871137f744f31781ab22e8f65f61d1/frame/system/src/offchain.rs#L471-L495
The text was updated successfully, but these errors were encountered: