Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pov-recovery ready for elastic scaling #3577

Closed
skunert opened this issue Mar 5, 2024 · 0 comments · Fixed by #4733
Closed

Make pov-recovery ready for elastic scaling #3577

skunert opened this issue Mar 5, 2024 · 0 comments · Fixed by #4733
Assignees
@alindima

Comments

@skunert
Copy link
Contributor

skunert commented Mar 5, 2024

After #3576 is done, we should adjust the pov-recovery side.
The current logic logic assumes that we get at maximum one candidate per relay chain block, which gave us some nice ordering. With multiple pending candidates per relay chain block, we need to ensure the correct ordering. Other than that, the current logic should still work.
@skunert skunert self-assigned this Mar 5, 2024
@sandreim sandreim mentioned this issue Mar 5, 2024
Closed
@alindima alindima assigned alindima and unassigned skunert Jun 5, 2024
@alindima alindima mentioned this issue Jun 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 10, 2024
@alindima
add pov-recovery unit tests and support for elastic scaling (#4733)
a3472c4 
- unit tests for pov-recovery
- elastic scaling support (recovering multiple candidates in a single
relay chain block)
- also some small cleanups
- also switches to candidates_pending_availability in
`handle_empty_block_announce_data`

Fixes #3577

After #4097 is merged, we
should also add a zombienet test, similar to the existing
`0002-pov_recovery.toml` but which has a single collator using elastic
scaling on multiple cores.
Ank4n pushed a commit that referenced this issue Jun 14, 2024
@alindima @Ank4n
add pov-recovery unit tests and support for elastic scaling (#4733)
04cdeff 
- unit tests for pov-recovery
- elastic scaling support (recovering multiple candidates in a single
relay chain block)
- also some small cleanups
- also switches to candidates_pending_availability in
`handle_empty_block_announce_data`

Fixes #3577

After #4097 is merged, we
should also add a zombienet test, similar to the existing
`0002-pov_recovery.toml` but which has a single collator using elastic
scaling on multiple cores.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@alindima @TarekkMA
add pov-recovery unit tests and support for elastic scaling (parityte…
fc79acf 
…ch#4733)

- unit tests for pov-recovery
- elastic scaling support (recovering multiple candidates in a single
relay chain block)
- also some small cleanups
- also switches to candidates_pending_availability in
`handle_empty_block_announce_data`

Fixes paritytech#3577

After paritytech#4097 is merged, we
should also add a zombienet test, similar to the existing
`0002-pov_recovery.toml` but which has a single collator using elastic
scaling on multiple cores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alindima alindima

Labels
None yet
Projects
SDK Node
Status: done
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add pov-recovery unit tests and support for elastic scaling paritytech/polkadot-sdk
2 participants
@skunert @alindima