Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] RemoteExternalities should only require Hasher #3737

Closed
ggwpez opened this issue Mar 18, 2024 · 2 comments · Fixed by #3953
Closed

[FRAME] RemoteExternalities should only require Hasher #3737

ggwpez opened this issue Mar 18, 2024 · 2 comments · Fixed by #3953
Assignees
@lean-apple
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 18, 2024

RemoteExternalities, OnlineConfig and Mode (maybe more) types in frame-remote-externalities require Block while only using its Hasher 🙄 This makes it more difficult to use and is entirely unnecessary. Should be refactored to only require Hasher/HashOutput where needed.

The only spot where we currently still need a Header, is on the Builder to access the ChainApi. IMHO this could be changed as well, since just loading the latest block hash should not require a header type, but it is outside of the scope for this issue.

(This issue does require some Rust knowledge about how trait bounds work)
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 18, 2024
@ggwpez ggwpez self-assigned this Mar 23, 2024
@lean-apple
Copy link
Contributor

May I work on this ?

@ggwpez ggwpez assigned lean-apple and unassigned ggwpez Mar 25, 2024
@ggwpez
Copy link
Member Author

ggwpez commented Mar 25, 2024

May I work on this ?

Sure 👍

@lean-apple lean-apple mentioned this issue Apr 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
@lean-apple @ggwpez @bkchr
Adapt RemoteExternalities and its related types to be used with gen…
d733c77 
…eric hash parameters (#3953)

Closes  #3737

---------

Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Ank4n pushed a commit that referenced this issue Apr 9, 2024
@lean-apple @ggwpez
@bkchr @Ank4n
Adapt RemoteExternalities and its related types to be used with gen…
0cc0af3 
…eric hash parameters (#3953)

Closes  #3737

---------

Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@lean-apple @ggwpez
@bkchr @dharjeezy
Adapt RemoteExternalities and its related types to be used with gen…
a952176 
…eric hash parameters (paritytech#3953)

Closes  paritytech#3737

---------

Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lean-apple lean-apple

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
2 participants
@ggwpez @lean-apple