Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCM: Remove require_weight_at_most from Transact #4284

Closed
Tracked by #481
franciscoaguirre opened this issue Apr 25, 2024 · 3 comments · Fixed by #4826
Closed
Tracked by #481

XCM: Remove require_weight_at_most from Transact #4284

franciscoaguirre opened this issue Apr 25, 2024 · 3 comments · Fixed by #4826
Assignees
@franciscoaguirre
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Apr 25, 2024 •
edited
Loading

The Transact instruction shouldn't need the require_weight_at_most parameter, since the decoder could just get the weight of the call from its dispatch info.

It might be difficult to estimate the weight needed for BuyExecution though.

Will probably have to go into XCMv5, to not break the format.
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Apr 25, 2024
@seadanda seadanda mentioned this issue Apr 25, 2024
Open
@acatangiu
Copy link
Contributor

RFC here polkadot-fellows/xcm-format#55

@acatangiu
Copy link
Contributor

RFC polkadot-fellows/RFCs#101 merged, more details there.

@acatangiu acatangiu assigned acatangiu and x3c41a and unassigned acatangiu Aug 13, 2024
@franciscoaguirre franciscoaguirre mentioned this issue Aug 16, 2024
Merged
10 tasks
@acatangiu acatangiu mentioned this issue Oct 14, 2024
Open
8 tasks
@programskillforverification
Copy link
Contributor

@franciscoaguirre @acatangiu how about progress of this issue? If not start, I want to try.

@franciscoaguirre franciscoaguirre mentioned this issue Oct 24, 2024
Merged
acatangiu pushed a commit that referenced this issue Oct 29, 2024
@franciscoaguirre
Transact without specifying weight (#6228)
a1b8381 
Addresses #4284

For V5, removed `required_weight_at_most` from `Transact`.
The weigher now has to decode the call inside of a transaction in order
to know it's dispatch weight.
It's harder to make mistakes now, since the user no longer specifies a
weight value which might be wrong.
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
@franciscoaguirre @acatangiu
@x3c41a @bkontur @programskillforverification @nazar-pc @bkchr @shawntabrizi @actions-user @serban300
XCM v5 (#4826)
85521e8 
# Context

This PR aims to introduce XCMv5, for now it's in progress and will be
updated over time.
This branch will serve as a milestone branch for merging in all features
we want to add to XCM, roughly outlined
[here](polkadot-fellows/xcm-format#60).
More features could be added.

## TODO
- [x] Migrate foreign assets from v3 to v4
- [x] Setup v5 skeleton
- [x] Remove XCMv2
- [x] #5390
- [x] #5585
- [x] #5420
- [x] #5876
- [x] #5971
- [x] #6148
- [x] #6228

Fixes #3434 
Fixes #4190
Fixes #5209
Fixes #5241
Fixes #4284

---------

Signed-off-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Andrii <ndk@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Joseph Zhao <65984904+programskillforverification@users.noreply.github.com>
Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Serban Iorga <serban@parity.io>
@github-project-automation github-project-automation bot moved this from Todo to Done in Bridges + XCM Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciscoaguirre franciscoaguirre

Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XCM v5 paritytech/polkadot-sdk
4 participants
@franciscoaguirre @acatangiu @programskillforverification @x3c41a