Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize session-related traits for different type of session management without buffering #463

Open
kianenigma opened this issue Apr 21, 2021 · 3 comments
Open

Generalize session-related traits for different type of session management without buffering #463

kianenigma opened this issue Apr 21, 2021 · 3 comments
Labels
I4-refactor Code needs refactoring.

Comments

@kianenigma
Copy link
Contributor

The current session pallet is hardcoded to always have 1 session delay, and all the surrounding traits (SessionManager, SessionHander, OneSessionHandler) are also somehow pointing at this.

If you were to write a custom session pallet with 2 sessions delay, or much more interesting, with no delay, then using these traits would become very awkward very soon.

All of these traits and pallets need some rework to allow you to be able to combine different flavors of validator/collator selection (e.g. pallet-staking) with session key management (i.e. pallet-session) and finally wire all of them to our consensus layer pallets, aura, babe, and grandpa.

A good amount of ideas and convo exists around this here: paritytech/substrate#8649
@kianenigma kianenigma changed the title Generalize session-related traits for different type of session management Generalize session-related traits for different type of session management without buffering Apr 21, 2021
@xlc xlc mentioned this issue May 27, 2021
Closed
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@kianenigma
Copy link
Contributor Author

will take some time, but this is super important actually.

@stale stale bot removed the A5-stale label Jul 8, 2021
@kianenigma
Copy link
Contributor Author

@gautamdhameja

@kianenigma kianenigma mentioned this issue Mar 19, 2022
Open
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I7-refactor labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@musnit
Merkle Proof tests (paritytech#463)
4380425 
* initial commit

* add solidity check

* working
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@dependabot
Bump tar from 4.4.15 to 4.4.19 in /template/examples/contract-hello (p…
f5d2fd8 
…aritytech#463)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.15...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I4-refactor Code needs refactoring.
Projects
(Nominated) Proof of Stake
Status: 📕 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kianenigma @the-right-joyce