-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Delay peer outbound connection in ProtocolController
if the dial failed
#494
Comments
ProtocolController
if the dial failedProtocolController
if the dial failed
We need some additional considerations for this whole behavior. If the dial fails, the address is considered undialable without any further testing. We should allow something like three failed dial attempts before the address is considered not working and can be removed. These dial attempts should not happen back to back because the node may be temporarily unavailable and later reachable again from the same address. Right now the addresses are removed after one failed dial attempt which means some of the peers in |
Currently, if the dial fails but the peer has high reputation, it's picked up as outbound connection candidate again, and dial is repeated on the next slot allocation (within a second). It would be nice to not dial such peers immediately.
Not super critical, but something to look into someday.
The text was updated successfully, but these errors were encountered: