Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/paritytech/substrate/pull/10688 doesn't take reserved nodes into account #533

Open
tomaka opened this issue Feb 5, 2022 · 3 comments
Open

https://github.com/paritytech/substrate/pull/10688 doesn't take reserved nodes into account #533

tomaka opened this issue Feb 5, 2022 · 3 comments
Assignees
@dmitry-markin

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 5, 2022

paritytech/substrate#10688 enforces the maximum number of peers, even if they were reserved.
@ggwpez ggwpez changed the title https://github.com/paritytech/substrate/pull/10688 doesn't take reserved nodes into account #10688 doesn't take reserved nodes into account Feb 5, 2022
@ggwpez ggwpez changed the title #10688 doesn't take reserved nodes into account https://github.com/paritytech/substrate/pull/10688 doesn't take reserved nodes into account Feb 5, 2022
@tomaka tomaka mentioned this issue Feb 11, 2022
Open
@dmitry-markin dmitry-markin self-assigned this Jul 21, 2022
@dmitry-markin
Copy link
Contributor

What is the desired behavior? Not to count reserved peer connections as occupying slots?

@tomaka
Copy link
Contributor Author

tomaka commented Jul 21, 2022

Indeed

@dmitry-markin dmitry-markin mentioned this issue Jul 25, 2022
Merged
@dmitry-markin dmitry-markin linked a pull request Jul 25, 2022 that will close this issue
Always allocate slots for reserved nodes paritytech/substrate#11909
Merged
@dmitry-markin dmitry-markin removed a link to a pull request Jul 28, 2022
Always allocate slots for reserved nodes paritytech/substrate#11909
Merged
@dmitry-markin
Copy link
Contributor

Partially resolved (for reserved nodes, added on startup) in paritytech/substrate#11909

We should also account for reserved nodes, added at runtime via RPC. To implement this, we should refactor Peerset first into a sync struct #529. See the discussion in paritytech/substrate#11909

@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@alistair-singh
SNO-104 Add destination parachain id as parameter. (paritytech#533)
49c94b0 
* added paraId to EthApp

* added event

* fixed e2e tests

* fixed benchmark code

* fixed formatting

* plumbing through pallet xcm to eth app

* added xcm executor to eth-app

* added origin and execute command

* fixed formatting

* fixed tests

* started building xcm message

* use weight estimate

* fixed formatting

* fixed error message

* refactoring out xcm from eth-app

* fixed tests and formatted code

* added xcm attributes

* re-used pallet-xcm instead of forwarding XcmExecutor manually

* converted amount to u128

* built source and destination locations

* buying of execution and deposit asset

* encoded AccountId

* added in weight calculation

* Renamed XcmAssetTransactor to XcmReserveTransfer

* do transfers from erc20 app

* fixed formatting

* whitespace change

* more whitespace

* removed old benchmarking file

* reset file to empty content

* removed crate alias

* updated erc20 app lock call and added in encoding of scale optional types

* fixed erc20 test

* fixed whitespace

* do xcm transfer after mint

* used two different encode calls for each case

* changed encodeCall to encodeCallWithParaId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-markin dmitry-markin

Labels
None yet
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomaka @dmitry-markin @altonen @the-right-joyce