Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses added using add_known_address are never cleaned up #540

Open
tomaka opened this issue Mar 26, 2021 · 4 comments
Open

Addresses added using add_known_address are never cleaned up #540

tomaka opened this issue Mar 26, 2021 · 4 comments
Assignees
@melekes
Labels
I2-bug The node fails to follow expected behavior.

Comments

@tomaka
Copy link
Contributor

tomaka commented Mar 26, 2021

They should be removed if we have failed to reach them.
@tomaka tomaka added the I3-bug label Mar 26, 2021
@tomaka tomaka mentioned this issue May 18, 2021
Merged
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@tomaka
Copy link
Contributor Author

tomaka commented Jul 8, 2021

Issue still relevant and important.

@stale stale bot removed the A5-stale label Jul 8, 2021
@melekes melekes self-assigned this Jan 1, 2023
@melekes
Copy link
Contributor

melekes commented Jan 6, 2023

So if I'm reading the code correctly, we do remove those addresses here.

https://github.com/paritytech/substrate/blob/8d17a16a5653974ec17ed617306606e9dbb6e4b4/client/network/src/discovery.rs#L546
removes addr from kademlia

@melekes melekes mentioned this issue Jan 6, 2023
Merged
@melekes
Copy link
Contributor

melekes commented Apr 7, 2023

@tomaka could you please clarify what's the issue about ^?

@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I2-bug The node fails to follow expected behavior. and removed I3-bug labels Aug 25, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@nanocryk
Async LRU cache for Ethereum block data (paritytech#540)
a630bd4 
* async block data cache

* fmt

* fmt (mix of tabs and spaces?)

* fmt (remove type annotation to stay inline)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
I2-bug The node fails to follow expected behavior.
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
4 participants
@melekes @tomaka @altonen @the-right-joyce