Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out raciness of past session slashing #623

Closed
eskimor opened this issue May 30, 2023 · 2 comments · Fixed by #1220
Closed

Figure out raciness of past session slashing #623

eskimor opened this issue May 30, 2023 · 2 comments · Fixed by #1220
Assignees
@ordian

Comments

@eskimor
Copy link
Member

eskimor commented May 30, 2023

I think the current implementation of past session slashing is a bit racy. We should discuss the problem and figure out improvements if necessary.

The issue in particular: Slashing only happens after a dispute concluded on chain, depending on load, weight/size of the disputed candidate, etc. this can take a while. We fear that an abandoned fork containing the disputed candidate might have fallen behind finality too much, so necessary information is no longer available. Being the mapping from candidate hash to block hash or state of the block in general.
@ordian
Copy link
Member

ordian commented May 30, 2023

Given there's an airbag of 2 blocks before finality, I don't see this is a huge issue. What we could do is use pinning API of substrate to not prune inclusion blocks of disputed invalid candidates until we finalize a fork with a slash in it.

@eskimor
Copy link
Member Author

eskimor commented May 30, 2023

That sounds interesting and makes a lot of sense conceptually!

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@ordian ordian self-assigned this Aug 24, 2023
This was referenced Aug 28, 2023
Closed
Merged
claravanstaden added a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@claravanstaden
Beacon block sync (paritytech#623)
1b5d8d5 
* Start working on beacon block sync

* Progress on beacon block verification

* Beacon block verification

* Block proof progress

* Updates ssz_rs version with transactions panic fix.

* Use tested individual merkleization functions in beacon block proof

* Beacon block proof works

* Beacon block with transactions and attester slashing also works

* Pins byte-slice-cast version, checks rust version

* remove ssz_rs rev

* Tries updating Rust version

* Updates ssz-rs name and version

* Updates ssz-rs version

* Updates ssz-rs-derive too

* Moves Beacon structs into primitives

* Adds new beacon primitive files

* Fixes no-std issues.

* Cleanup and refactor.

* More cleanup

* PR comments

* Merged main

Co-authored-by: claravanstaden <Cats 4 life!>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
f1e18c2
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
f34a182
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
1c85f68
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
b3a73fd
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
56b1eb0
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
3740190
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
c244b70
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
950de63
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
02d63ca
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
766c07d
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
743f340
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@adoerr @serban300
reference correct relayer startup script in readme (paritytech#623)
ef41374
bkchr pushed a commit that referenced this issue Apr 10, 2024
@adoerr @bkchr
reference correct relayer startup script in readme (#623)
a30b2ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ordian ordian

Labels
None yet
Projects
No open projects
Disputes + Slashing + Rewards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

polkadot: pin one block per session paritytech/polkadot-sdk
2 participants
@eskimor @ordian