Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional labels for host functions #643

Closed
chevdor opened this issue May 8, 2023 · 2 comments
Closed

Add additional labels for host functions #643

chevdor opened this issue May 8, 2023 · 2 comments

Comments

@chevdor
Copy link
Contributor

chevdor commented May 8, 2023

Suggestion from @koute from paritytech/polkadot#7158

Suggestion

  • one label for when we introduce a new host function (host function is not used yet, so no need for everyone to upgrade; low priority)
  • one label for when we enable a previously unused host function (everyone has to upgrade; high priority)
  • one label for when we modify a previously unused but already existing in in-the-wild host function (so that if we enable it we know what is the oldest version of node that's still compatible)

cc @the-right-joyce

@chevdor
Copy link
Contributor Author

chevdor commented May 8, 2023

This kind of granularity allows being super accurate when listing/grouping those PRs.

This will however only work if those extra labels are used properly by everyone and picking the right set of labels has an overhead. We have already lots of labels and I know the amount if already daunting. That being said, the number of people working around host functions is limited so it may work.

@the-right-joyce
Copy link
Contributor

as we're currently re-working on labels and we will need a new release process for the monorepo, I'd say we don't start tinkering around now
But the idea is good and should be include in: paritytech/labels#25

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
* fp-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* pallet-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* fc-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* template: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy support for CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix rpc-core

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Improve CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy component

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make test more stable

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants