Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix any code that relies on ParaId -> CoreIndex assignment to be static #664

Closed
eskimor opened this issue Apr 7, 2023 · 3 comments
Closed
Assignees

Comments

@eskimor
Copy link
Member

eskimor commented Apr 7, 2023

We might still have some code that does not take into account that the association ParaId to CoreIndex can change from block to block.

Comment by Rob:

I think a lot of the places where that assumption is made would manifest as validators accepting or even backing collations for parachains that aren't actually scheduled, although the runtime will not accept such blocks.

As well as not recognizing that the "next up" chain is scheduled - this wouldn't manifest until we have pay-as-you-go cores maxed out.

Therefore, apart from checking the code we should especially make sure to have a test that maxes out all the available on-demand cores.

@eskimor
Copy link
Member Author

eskimor commented Aug 17, 2023

@antonva also a good ticket to work on.

@antonva antonva self-assigned this Aug 17, 2023
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@eskimor
Copy link
Member Author

eskimor commented Jan 30, 2024

All good according to @antonva

@eskimor eskimor closed this as completed Jan 30, 2024
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…ng (paritytech#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
bkchr pushed a commit that referenced this issue Apr 10, 2024
…ng (#664)

* emit dispatch message when whole message (payload) has invalid encoding

* DispatchMessage::dispatch accepts Result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Status: In Progress
Development

No branches or pull requests

2 participants