Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving error specificity: ParaLocked instead of BadOrigin in ensure_root_para_or_owner #6745

Closed
2 tasks done
ipapandinas opened this issue Dec 3, 2024 · 0 comments · Fixed by #6989
Closed
2 tasks done

Improving error specificity: ParaLocked instead of BadOrigin in ensure_root_para_or_owner #6745

ipapandinas opened this issue Dec 3, 2024 · 0 comments · Fixed by #6989
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@ipapandinas
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

While attempting to deregister a parachain using the manager account, I encountered a BadOrigin error. Upon investigation, the issue was that the parachain was locked, and a ParaLocked error would have provided more clarity.

It seems that BadOrigin from ensure_parachain might be overriding other contextually relevant errors here, such as ParaLocked. Is this the intended behavior? If not, I can propose a fix to avoid this error overriding and improve the user experience.

Steps to reproduce

  1. Deregister a locked parachain using the manager account.
  2. Notice the BadOrigin error.
@ipapandinas ipapandinas added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Dec 3, 2024
@bkchr bkchr mentioned this issue Dec 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 27, 2024
@bkchr
paras-registrar: Improve error reporting (#6989)
b7afe48 
This pr improves the error reporting by paras registrar when an owner
wants to access a locked parachain.

Closes: #6745

---------

Co-authored-by: command-bot <>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@bkchr @dudo50
paras-registrar: Improve error reporting (paritytech#6989)
526246a 
This pr improves the error reporting by paras registrar when an owner
wants to access a locked parachain.

Closes: paritytech#6745

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

paras-registrar: Improve error reporting paritytech/polkadot-sdk
1 participant
@ipapandinas