Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extrinsics in nomination pool pallet are missing events #7370

Closed
rockbmb opened this issue Jan 28, 2025 · 0 comments · Fixed by #7377
Closed

Extrinsics in nomination pool pallet are missing events #7370

rockbmb opened this issue Jan 28, 2025 · 0 comments · Fixed by #7377
Assignees
@rockbmb
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@rockbmb
Copy link
Contributor

rockbmb commented Jan 28, 2025

From pallet_nomination_pool, the extrinsics

  • set_configs
  • chill
  • set_claim_permission
  • set_metadata

do not currently emit events.
@rockbmb rockbmb added C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Jan 28, 2025
@bkchr bkchr removed the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Jan 28, 2025
@rockbmb rockbmb mentioned this issue Jan 29, 2025
Merged
@rockbmb rockbmb self-assigned this Jan 29, 2025
@rockbmb rockbmb mentioned this issue Jan 31, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
@rockbmb @Ank4n
Add missing events to nomination pool extrinsincs (#7377)
a883475 
Found via
open-web3-stack/polkadot-ecosystem-tests#165.

Closes #7370 .

# Description

Some extrinsics from `pallet_nomination_pools` were not emitting events:
* `set_configs`
* `set_claim_permission`
* `set_metadata`
* `chill`
* `nominate`

## Integration

N/A

## Review Notes

N/A

---------

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rockbmb rockbmb

Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing events to nomination pool extrinsincs paritytech/polkadot-sdk
2 participants
@bkchr @rockbmb