Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests to remove overseer send and recv timeouts #764

Open
ordian opened this issue Oct 12, 2022 · 0 comments
Open

refactor tests to remove overseer send and recv timeouts #764

ordian opened this issue Oct 12, 2022 · 0 comments
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T10-tests This PR/Issue is related to tests.

Comments

@ordian
Copy link
Member

ordian commented Oct 12, 2022

Currently we have a few places with duplicated fn overseer_send and fn_overseer_recv functions: https://cs.github.com/paritytech/polkadot?q=fn+overseer_send
The subsystems have different test timeouts piled on top of the timeout defined in https://github.com/paritytech/polkadot/blob/15709eee181d927ec80d566e882931776182bdcd/node/subsystem-test-helpers/src/lib.rs#L248-L251

We should remove these functions, lower the timeout to 10s in test-helpers and just use overseer.send(msg) (maybe add a helper function so that we don't have to wrap it in FromOrchestra::Communication) and overseer.recv.

The low timeouts < 1s create spurious CI errors like https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1941785 which we never can reproduce locally.
@ordian ordian mentioned this issue Oct 12, 2022
Merged
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T10-tests This PR/Issue is related to tests. T8-parachains_engineering and removed I4-annoyance labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@doubledup
Set node & pnpm versions in package.json (paritytech#764)
7c80678
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@AurevoirXavier
Avoid Extra Allocation (paritytech#764)
d80c5fe
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
f13e1b2 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
511a80d 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
cdaec39 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
90039a1 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
d44916a 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
ed7197b 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
2e0a86b 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
8d2b32b 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
785c0c8 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
b6af033 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
0f3694e 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @serban300
Add few CLI helpers (paritytech#764)
5373f7a 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @bkchr
Add few CLI helpers (#764)
3764cda 
* Adding call encoding.

* Add message payload encoding.

* Nicer output.

* Add fee estimation.

* cargo fmt --all

* Split message payload encoding into separate command.

* Use HexBytes.

* cargo fmt --all

* Fix compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T10-tests This PR/Issue is related to tests.
Projects
parachains team board
Status: Backlog
Parachains-core
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ordian @the-right-joyce