Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookahead collator: read allowed ancestry len from relay client #1180

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Aug 25, 2023

Implements 2nd approach from paritytech/cumulus#2706 (comment)

@slumber slumber requested a review from rphmeier August 25, 2023 17:18
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it's supposed to.

Even better would be to extract out a fn load_abridged_host_configuration to cumulus/client/consensus/common.

@slumber
Copy link
Contributor Author

slumber commented Aug 25, 2023

Does what it's supposed to.

Even better would be to extract out a fn load_abridged_host_configuration to cumulus/client/consensus/common.

I thought about making it a part of relay client, but e.g.

let ingress_channels = relay_chain_interface
.get_storage_by_key(
relay_parent,
&relay_well_known_keys::hrmp_ingress_channel_index(para_id),
)
.await
.map_err(|e| {
tracing::error!(
target: LOG_TARGET,
relay_parent = ?relay_parent,
error = ?e,
"Cannot obtain the hrmp ingress channel."
)
})
.ok()?;

Just uses get_storage_by_key explicitly with localized log target.

@slumber
Copy link
Contributor Author

slumber commented Sep 8, 2023

bot merge

@command-bot
Copy link

command-bot bot commented Sep 8, 2023

@slumber Unknown command "merge". Refer to help docs and/or source code.

@slumber slumber enabled auto-merge (squash) September 8, 2023 15:41
@slumber slumber merged commit 60d1a0b into master Sep 8, 2023
7 of 8 checks passed
@slumber slumber deleted the slumber-aura-read-async-backing-params branch September 8, 2023 16:05
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Read allowed ancestry len from active config

* extract load_abridged_host_configuration

---------

Co-authored-by: Javier Viola <javier@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* substrate: d0f6c1c
polkadot: dd4b2e6
cumulus: 9379cd6c1863ea846ad6c6a8cbbc99848dd5d693

* fmt

* fixed lost refs

* spelling

* benckhmarks

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants