Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backing: move the min votes threshold to the runtime #1200

Merged
merged 15 commits into from
Aug 31, 2023
Merged

backing: move the min votes threshold to the runtime #1200

merged 15 commits into from
Aug 31, 2023

Commits on Aug 28, 2023

  1. move min backing votes const to runtime 

    also cache it per-session in the backing subsystem

Signed-off-by: alindima <alin@parity.io>
    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f140a37 View commit details
    Browse the repository at this point in the history

  2. add runtime migration

    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a6664a4 View commit details
    Browse the repository at this point in the history

  3. introduce api versioning for min_backing votes 

    also enable it for rococo/versi for testing
    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    62783af View commit details
    Browse the repository at this point in the history

  4. also add min_backing_votes runtime calls to statement-distribution 

    this dependency has been recently introduced by async backing
    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8718818 View commit details
    Browse the repository at this point in the history

  5. remove explicit version runtime API call 

    this is not needed, as the RuntimeAPISubsystem already takes care
of versioning and will return NotSupported if the version is not
right.
    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    be44e33 View commit details
    Browse the repository at this point in the history

  6. address review comments 

    - parametrise backing votes runtime API with session index
- remove RuntimeInfo usage in backing subsystem, as runtime API
caches the min backing votes by session index anyway.
- move the logic for adjusting the configured needed backing votes with the size of the backing group
to a primitives helper.
- move the legacy min backing votes value to a primitives helper.
- mark JoinMultiple error as fatal, since the Canceled (non-multiple) counterpart is also fatal.
- make backing subsystem handle fatal errors for new leaves update.
- add HostConfiguration consistency check for zeroed backing votes threshold
- add cumulus accompanying change
    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e7e82bc View commit details
    Browse the repository at this point in the history

  7. fix cumulus test compilation

    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    533f6c9 View commit details
    Browse the repository at this point in the history

  8. fix tests

    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8adf595 View commit details
    Browse the repository at this point in the history

  9. more small fixes

    @alindima
    alindima committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    34fa138 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Merge remote-tracking branch 'origin/master' into alindima-add-min-ba… 

    …cking-votes-to-runtime
    @alindima
    alindima committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    200537e View commit details
    Browse the repository at this point in the history

  2. fix merge

    @alindima
    alindima committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3f594a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Merge branch 'master' into alindima-add-min-backing-votes-to-runtime

    @pepoviola
    pepoviola authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    fa0a515 View commit details
    Browse the repository at this point in the history

  2. bump runtime api version for westend and rollback version for rococo

    @alindima
    alindima committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    cd6485b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into alindima-add-min-backing-votes-to-runtime

    @alindima
    alindima authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    75bc7e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Merge branch 'master' into alindima-add-min-backing-votes-to-runtime

    @alindima
    alindima authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8c1cb7f View commit details
    Browse the repository at this point in the history