-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve docs]: Sudo Pallet #1209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacha-l
added
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
R0-silent
Changes should not be mentioned in any release notes
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
T11-documentation
This PR/Issue is related to documentation.
labels
Aug 28, 2023
…itytech/polkadot-sdk into sl/sudo-pallet-docs-refactor
juangirini
approved these changes
Aug 28, 2023
kianenigma
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, please reflect
Note: I'm suggesting that we bring the "Pallet API" section further up to make readers more aware of its existence. This section seems a little buried in the other content otherwise.
In the guideline and other pallets as well :)
franciscoaguirre
approved these changes
Sep 4, 2023
sam0x17
approved these changes
Sep 5, 2023
Co-authored-by: Juan <juangirini@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
* refactor docs * add docify * nit * add #![deny(missing_docs)] * Apply suggestions from code review Co-authored-by: Juan <juangirini@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Juan <juangirini@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* unify metric names * refactor standalone metrics * headers sync metrics * post-merge fix * fix compilation * fmt * fix dashboards * fix local dashboards * update Rococo/Wococo runtime version * remove commented code * fixed grumbles * fmt * fixed widget names
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
R0-silent
Changes should not be mentioned in any release notes
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
T11-documentation
This PR/Issue is related to documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the docs for the Sudo pallet by following our Documentation Guidelines more closely.
It also adds the docsify crate to surface code snippets in the Examples section.
Note: I'm suggesting that we bring the "Pallet API" section further up to make readers more aware of its existence. This section seems a little buried in the other content otherwise.