Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot: less flaky dispute slashing test #1218

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

ordian
Copy link
Member

@ordian ordian commented Aug 28, 2023

Part of #578

@ordian ordian added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Aug 28, 2023
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual slashing does not seem to be tested here?

@ordian
Copy link
Member Author

ordian commented Aug 28, 2023

The actual slashing does not seem to be tested here?

Correct. Zombienet currently allows matching on system events only with zndsl and slashing is displayed with the staking event. It is possible to write some custom js assertion though, but I would like to avoid that at all costs 🙈
We are testing though that the slashing report was submitted and relying on the offences pallet to dispatch it correctly.

Of course the actual slashing event was observed with polkadot js:
Screenshot 2023-08-28 at 18 56 47

@ordian ordian merged commit 7125f65 into master Aug 28, 2023
7 of 8 checks passed
@ordian ordian deleted the ao-less-flaky-dispute-slashing-test branch August 28, 2023 17:03
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants