Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add production and release profile #1238

Closed
wants to merge 5 commits into from
Closed

Add production and release profile #1238

wants to merge 5 commits into from

Conversation

alvicsam
Copy link
Contributor

Needed for fixing errors in command-bot (e.g. #1235)

@alvicsam alvicsam requested a review from ggwpez August 29, 2023 08:15
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Aug 29, 2023
@alvicsam alvicsam requested a review from a team August 29, 2023 08:21
koute
koute reviewed Aug 29, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@alvicsam @koute
Update Cargo.toml
b47eca6 
Co-authored-by: Koute <koute@users.noreply.github.com>
@chevdor
Copy link
Contributor

chevdor commented Aug 29, 2023

Why removing some of the flags compared to https://github.com/paritytech/polkadot/blob/master/Cargo.toml#L202-L215 ?

chevdor
chevdor approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focusing on the production profile, this LGTM once we add the flags we have in the polkadot repo.

Cargo.toml Show resolved Hide resolved
@koute
Copy link
Contributor

koute commented Aug 29, 2023

Why removing some of the flags compared to https://github.com/paritytech/polkadot/blob/master/Cargo.toml#L202-L215 ?

The release profile has opt-level set to 3 by default so it's not necessary to add that in, and as for the production profile we just added it back. :P

alvicsam and others added 3 commits August 29, 2023 10:56
@alvicsam
move other profiles from polkadot
c22c8b6
@alvicsam @chevdor
Update Cargo.toml
942743c 
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@alvicsam
apply zepter
8608d04
@bkchr
Copy link
Member

bkchr commented Aug 29, 2023

Duplicate of: #1229

@alvicsam alvicsam closed this Aug 29, 2023
@alvicsam alvicsam deleted the as-ad-profiles branch August 29, 2023 09:28
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
8f787f8 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
dad9d52 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
fac18a8 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
f27c549 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
18facbc 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
6b614c1 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
ba85c3b 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
5bd4ccf 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
5cd5d00 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
b3a89e5 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
305f7a3 
* fixed storage_parameter_key

* added test for storage_parameter_key
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Fix storage parameter name computation (paritytech#1238)
11bae6b 
* fixed storage_parameter_key

* added test for storage_parameter_key
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Fix storage parameter name computation (#1238)
edd1724 
* fixed storage_parameter_key

* added test for storage_parameter_key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koute koute koute left review comments

@chevdor chevdor chevdor approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvicsam @chevdor @koute @bkchr