Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XCMP max message size check #1250

Merged
merged 14 commits into from
Dec 4, 2023
Merged

Fix XCMP max message size check #1250

merged 14 commits into from
Dec 4, 2023

Conversation

vstam1
Copy link
Contributor

@vstam1 vstam1 commented Aug 29, 2023 •
edited by franciscoaguirre
Loading

Improved max message size logic and added test for it

@franciscoaguirre franciscoaguirre self-assigned this Sep 9, 2023
@bkchr
Copy link
Member

bkchr commented Nov 29, 2023

@franciscoaguirre what is the status of this?

@franciscoaguirre
Copy link
Contributor

Gonna be working on it now

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Dec 4, 2023
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner December 4, 2023 17:33
@franciscoaguirre franciscoaguirre changed the title fix max message size Fix XCMP max message size check Dec 4, 2023
ggwpez
ggwpez approved these changes Dec 4, 2023
View reviewed changes
cumulus/pallets/xcmp-queue/src/lib.rs Outdated Show resolved Hide resolved
polkadot/xcm/procedural/src/builder_pattern.rs Outdated Show resolved Hide resolved
@franciscoaguirre
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 4, 2023 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4599973 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-9a03ea82-7cac-4631-909d-f77828a22ade to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 4, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4599973 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4599973/artifacts/download.

@franciscoaguirre franciscoaguirre added the T2-pallets This PR/Issue is related to a particular pallet. label Dec 4, 2023
@franciscoaguirre franciscoaguirre removed the T6-XCM This PR/Issue is related to XCM. label Dec 4, 2023
@franciscoaguirre franciscoaguirre enabled auto-merge (squash) December 4, 2023 18:34
@franciscoaguirre franciscoaguirre added the R0-silent Changes should not be mentioned in any release notes label Dec 4, 2023
@franciscoaguirre franciscoaguirre merged commit a9738ad into master Dec 4, 2023
116 of 117 checks passed
@franciscoaguirre franciscoaguirre deleted the vstam1/fix-max-message-size-limit branch December 4, 2023 22:02
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
0cb5616 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
2935394 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
9f92ecb 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
35ce392 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
c43b5d3 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
55d8c7d 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
9464199 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
4a94de7 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
92afb1a 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
7a34796 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
4f0880e 
* add missing RPC APIs to rialto parachain node

* spellcheck
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Add missing RPC APIs to rialto parachain node (paritytech#1250)
07a48d0 
* add missing RPC APIs to rialto parachain node

* spellcheck
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Add missing RPC APIs to rialto parachain node (#1250)
ecd7687 
* add missing RPC APIs to rialto parachain node

* spellcheck
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur Awaiting requested review from bkontur

Assignees

@franciscoaguirre franciscoaguirre

Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstam1 @bkchr @franciscoaguirre @bkontur @ggwpez