Fix links in contributing and PR template docs #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
approved these changes
Aug 30, 2023
the-right-joyce
approved these changes
Aug 30, 2023
docs/CONTRIBUTING.md
Outdated
| @@ -34,7 +34,7 @@ No PR should be merged until all reviews' comments are addressed. | |||
|
|
|||
| ### Labels: | |||
|
|
|||
| The set of labels and their description can be found [here](linktobeinserted) | |||
| The set of labels and their description can be found [here](https://paritytech.github.io/labels). | |||
There was a problem hiding this comment.
maybe we can link directly to: https://paritytech.github.io/labels/doc_polkadot-sdk.html
lexnv
approved these changes
Aug 30, 2023
sacha-l
commented
Aug 30, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* add link to labels doc * add absolute links in PR template * Update docs/CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR template when, if previewed when actually making a PR, does not resolve to the expected doc. This fixes that by adding the absolute URL to that doc. And also updates the
linktobeinsertedin CONTRIBUTING.md with https://paritytech.github.io/labels.