add Treasurer to SchedulerOrigin #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 31, 2023
bkchr
added
the
T8-polkadot
|
This doesn't seem inherently wrong, but we already have a solution for this, namely the |
| @@ -215,7 +215,8 @@ impl pallet_scheduler::Config for Runtime { | |||
| type MaximumWeight = MaximumSchedulerWeight; | |||
| // The goal of having ScheduleOrigin include AuctionAdmin is to allow the auctions track of | |||
| // OpenGov to schedule periodic auctions. | |||
| type ScheduleOrigin = EitherOf<EnsureRoot<AccountId>, AuctionAdmin>; | |||
| // Also allow Treasurer to schedule recurring payments. | |||
| type ScheduleOrigin = EitherOf<EitherOf<EnsureRoot<AccountId>, AuctionAdmin>, Treasurer>; | |||
There was a problem hiding this comment.
Seems more readable since root is "special" although perhaps the tracks should go into a tuple to avoid further EitherOf nesting?
Suggested change
| type ScheduleOrigin = EitherOf<EitherOf<EnsureRoot<AccountId>, AuctionAdmin>, Treasurer>; | |
| type ScheduleOrigin = EitherOf<EnsureRoot<AccountId>, EitherOf<Treasurer, AuctionAdmin>>; |
There was a problem hiding this comment.
Agreed on tuple, this is much more readable:
Suggested change
| type ScheduleOrigin = EitherOf<EitherOf<EnsureRoot<AccountId>, AuctionAdmin>, Treasurer>; | |
| type ScheduleOrigin = (EnsureRoot<AccountId>, AuctionAdmin, Treasurer); |
However, I just took a look and realized that EnsureOrigin doesn't have implementations on tuples, so we can't write this.
gavofyork
approved these changes
Aug 31, 2023
KiChjang
approved these changes
Aug 31, 2023
Ank4n
pushed a commit
that referenced
this pull request
Sep 8, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it will be possible to schedule recurring payments using Treasurer track.
Original PR paritytech/polkadot#7637