Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xcm-emulator] Redo Parachain init #1356

Merged
merged 5 commits into from
Sep 4, 2023
Merged

[xcm-emulator] Redo Parachain init #1356

merged 5 commits into from
Sep 4, 2023

Conversation

NachoPal
Copy link
Contributor

@NachoPal NachoPal commented Sep 1, 2023

Fixes paritytech/cumulus#3023

The rest of the failing tests due to runtime-benchamrks feature are fixed here: #1247

In regard to this comment, proper Parachain initialisation done here never reached master after paritytech/cumulus#2300 was merged.

Parachain initialisation has been redone and refactored.

@NachoPal NachoPal requested a review from gilescope September 1, 2023 17:19
@NachoPal NachoPal added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Sep 1, 2023
@NachoPal
Copy link
Contributor Author

NachoPal commented Sep 1, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Sep 1, 2023 •
edited
Loading

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3533007 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-02adaf19-52a5-458d-9112-a5cbe8a3bb71 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 1, 2023

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3533007 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3533007/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3533019

@gilescope gilescope requested review from muharem and bkontur September 2, 2023 07:48
@NachoPal NachoPal mentioned this pull request Sep 2, 2023
Merged
@NachoPal @gilescope
Update cumulus/xcm/xcm-emulator/src/lib.rs
7b4ed1f 
Co-authored-by: Squirrel <gilescope@gmail.com>
@NachoPal NachoPal enabled auto-merge (squash) September 4, 2023 09:30
@NachoPal NachoPal merged commit 2c35bc3 into master Sep 4, 2023
@NachoPal NachoPal deleted the nacho/redo-xcm-emulator-init branch September 4, 2023 10:30
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
@NachoPal @gilescope @Ank4n
[xcm-emulator] Redo Parachain init (#1356)
b14a908 
* bring back proper init

* refactor block cycle

* ".git/.scripts/commands/fmt/fmt.sh"

* Update cumulus/xcm/xcm-emulator/src/lib.rs

Co-authored-by: Squirrel <gilescope@gmail.com>

---------

Co-authored-by: command-bot <>
Co-authored-by: Giles Cope <gilescope@gmail.com>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@NachoPal @gilescope @Daanvdplas
[xcm-emulator] Redo Parachain init (#1356)
431caac 
* bring back proper init

* refactor block cycle

* ".git/.scripts/commands/fmt/fmt.sh"

* Update cumulus/xcm/xcm-emulator/src/lib.rs

Co-authored-by: Squirrel <gilescope@gmail.com>

---------

Co-authored-by: command-bot <>
Co-authored-by: Giles Cope <gilescope@gmail.com>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

@gilescope gilescope gilescope approved these changes

@muharem muharem Awaiting requested review from muharem

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NachoPal @paritytech-cicd-pr @gilescope @bkontur