-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CODEOWNERS
Part 2
#1415
Merge CODEOWNERS
Part 2
#1415
Changes from all commits
416445d
d863704
295a36f
ddf3bc0
c89f540
17562f1
16dca98
b61b49e
ceb81be
e399c2e
9433404
294528e
e50e9e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,95 @@ | ||||
# Lists some code owners. | ||||
# | ||||
# A codeowner just oversees some part of the codebase. If an owned file is changed then the | ||||
# corresponding codeowner receives a review request. An approval of the codeowner might be | ||||
# required for merging a PR (depends on repository settings). | ||||
# | ||||
# For details about syntax, see: | ||||
# https://help.github.com/en/articles/about-code-owners | ||||
# But here are some important notes: | ||||
# | ||||
# - Glob syntax is git-like, e.g. `/core` means the core directory in the root, unlike `core` | ||||
# which can be everywhere. | ||||
# - Multiple owners are supported. | ||||
# - Either handle (e.g, @github_user or @github/team) or email can be used. Keep in mind, | ||||
# that handles might work better because they are more recognizable on GitHub | ||||
# and you can use them for mentioning unlike an email. | ||||
# - The latest matching rule, if multiple, takes precedence. | ||||
|
||||
# Top levels | ||||
/.cargo @paritytech/ci | ||||
/.config @paritytech/ci | ||||
/.github @paritytech/ci @paritytech/release-engineering | ||||
/.gitlab @paritytech/ci | ||||
/bridges @paritytech/bridges-core | ||||
/cumulus @paritytech/cumulus-locks-review @paritytech/core-devs | ||||
/docker @paritytech/ci @paritytech/release-engineering | ||||
/docs @paritytech/docs-audit | ||||
/polkadot @paritytech/polkadot-review | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm, I think this was previously only needed for runtime files, which are going to be migrated to https://github.com/polkadot-fellows/runtimes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you suggesting using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, probably start with not too strict rules and enforce other rules via PRCR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes the idea here is not to be too strict but have "full" coverage for the relevant files (ie all files but things like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is definitely too strict There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
/polkadot/xcm @paritytech/xcm | ||||
/scripts/ci @paritytech/ci @paritytech/release-engineering | ||||
/substrate @paritytech/SubstrateTeamLeads | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
/prdoc @paritytech/release-engineering | ||||
|
||||
.gitlab-ci.yml @paritytech/ci | ||||
.rustfmt.toml @paritytech/core-devs | ||||
Cargo.toml @paritytech/core-devs | ||||
*.md @paritytech/docs-audit | ||||
|
||||
chevdor marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
# WASM executor, low-level client <-> WASM interface and other WASM-related code | ||||
/substrate/client/allocator/ @koute | ||||
/substrate/client/executor/ @koute | ||||
/substrate/primitives/panic-handler/ @koute | ||||
/substrate/primitives/runtime-interface/ @koute | ||||
/substrate/primitives/wasm-interface/ @koute | ||||
/substrate/utils/wasm-builder/ @koute | ||||
|
||||
# Systems-related bits and bobs on the client side | ||||
/substrate/client/sysinfo/ @koute | ||||
/substrate/client/tracing/ @koute | ||||
|
||||
# Documentation audit | ||||
/substrate/primitives/runtime @paritytech/docs-audit | ||||
/substrate/primitives/arithmetic @paritytech/docs-audit | ||||
# /primitives/core (to be added later) | ||||
# /primitives/io (to be added later) | ||||
|
||||
chevdor marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
# Networking-related code | ||||
/substrate/client/network @paritytech/networking | ||||
|
||||
# FRAME | ||||
/substrate/frame/ @paritytech/frame-coders @paritytech/docs-audit | ||||
/substrate/frame/nfts/ @jsidorenko @paritytech/docs-audit | ||||
/substrate/frame/state-trie-migration/ @paritytech/frame-coders @cheme | ||||
/substrate/frame/uniques/ @jsidorenko @paritytech/docs-audit | ||||
|
||||
# GRANDPA, BABE, consensus stuff | ||||
/substrate/client/consensus/babe/ @andresilva | ||||
acatangiu marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
/substrate/client/consensus/beefy/ @acatangiu | ||||
/substrate/client/consensus/grandpa/ @andresilva | ||||
/substrate/client/consensus/pow/ @sorpaas | ||||
/substrate/client/consensus/slots/ @andresilva | ||||
/substrate/frame/babe/ @andresilva | ||||
/substrate/frame/grandpa/ @andresilva | ||||
/substrate/primitives/consensus/pow/ @sorpaas | ||||
|
||||
# BEEFY, MMR | ||||
/substrate/frame/beefy/ @acatangiu | ||||
/substrate/frame/beefy-mmr/ @acatangiu | ||||
/substrate/frame/merkle-mountain-range/ @acatangiu | ||||
/substrate/primitives/merkle-mountain-range/ @acatangiu | ||||
|
||||
# Contracts | ||||
/substrate/frame/contracts/ @athei @paritytech/docs-audit | ||||
|
||||
# NPoS and election | ||||
/substrate/frame/election-provider-multi-phase/ @paritytech/staking-core @paritytech/docs-audit | ||||
/substrate/frame/election-provider-support/ @paritytech/staking-core @paritytech/docs-audit | ||||
/substrate/frame/elections-phragmen/ @paritytech/staking-core @paritytech/docs-audit | ||||
/substrate/frame/nomination-pools/ @paritytech/staking-core @paritytech/docs-audit | ||||
/substrate/frame/staking/ @paritytech/staking-core @paritytech/docs-audit | ||||
/substrate/primitives/npos-elections/ @paritytech/staking-core @paritytech/docs-audit | ||||
|
||||
# Cumulus | ||||
/cumulus/xcm/xcm-emulator @nachopal | ||||
/cumulus/parachains/integration-tests @nachopal |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.