Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor: Remove LegacyInstanceReuse strategy #1486

Merged
merged 19 commits into from
Sep 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
yjhmelody committed Sep 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f8e6eae9e3c00fb5acb23240ac1b25d2da58c019
4 changes: 2 additions & 2 deletions substrate/client/executor/src/integration_tests/linux.rs
Original file line number Diff line number Diff line change
@@ -79,6 +79,6 @@ fn memory_consumption(wasm_method: WasmExecutionMethod) {
)
.unwrap();

assert_eq!(probe_rss(probe_1), Some(0));
assert_eq!(probe_rss(probe_2), Some(0));
assert_eq!(probe_rss(probe_1.unwrap()), 0);
assert_eq!(probe_rss(probe_2.unwrap()), 0);
}
Original file line number Diff line number Diff line change
@@ -175,7 +175,7 @@ impl InstanceWrapper {
Ok(InstanceWrapper { instance, store })
}

// *Only for test*
/// **Testing Only**.
pub(crate) fn base_ptr(&mut self) -> *const u8 {
let mem = self.store.data().memory();
mem.data_ptr(self.store.as_context_mut())
2 changes: 1 addition & 1 deletion substrate/client/executor/wasmtime/src/runtime.rs
Original file line number Diff line number Diff line change
@@ -127,7 +127,7 @@ impl WasmtimeInstance {
}
}

/// **Testing Only**. This function returns the base address of the linear memory.
/// **Testing Only**.
fn call_impl_with_base_ptr(
&mut self,
method: InvokeMethod,