Revert #1409 partially #1603
Merged
Revert #1409 partially #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A0-needs_burnin
sandreim
reviewed
Sep 18, 2023
|
|
||
| if delayed_messages_count > 0 { | ||
| // Here we wait for all the delayed messages to be sent. | ||
| let _timer = metrics.time_delayed_rx_events(); // Dropped after `await` is completed |
There was a problem hiding this comment.
This metric is useful, why not keep it ?
There was a problem hiding this comment.
This PR just reverts the "bad things", so I've decided to leave it as simple and quick as possible. I'm working on a better version in the meantime on top of this one.
rphmeier
approved these changes
Sep 18, 2023
sandreim
approved these changes
Sep 18, 2023
|
bot merge |
|
@vstakhov |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Futures channels that are used by default has a side effect of
Sender::Clonethat efficiently increases the capacity of the bounded channel by one. This PR fixes the undesired backpressure removal that was caused by the #1409. This issue has been discovered by @sandreim during Versi testing and needs to be treated as critical that should not be included in any release without this reversion.This PR reverts the original behaviour that can be slightly improved without cloning the sender.